fix(firestore): revert changes to isLessThan
, isLessThanOrEqualTo
,isGreaterThan
, isGreaterThanOrEqualTo
& arrayContains
. null
is not valid..
#12017
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the linked issue, I double checked on android. These queries
![screenshot_2023-12-12_at_10 45 51_720](https://private-user-images.githubusercontent.com/16018629/289833078-945af889-afca-4e25-a35e-86816d32ece4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA3NTAyNzAsIm5iZiI6MTcyMDc0OTk3MCwicGF0aCI6Ii8xNjAxODYyOS8yODk4MzMwNzgtOTQ1YWY4ODktYWZjYS00ZTI1LWEzNWUtODY4MTZkMzJlY2U0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEyVDAyMDYxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRmNTVhZDY5NDk2Mzc5ZmZiNTVhODlmMWNhZWMxYmFhMzE3YWJlY2IzYWVlZjY5ZmFiMDlmYmZjMDkyMDU0OGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.gcipcpSp--zyJE8QeQJQ-KSDdWTMSU-nRNVxX8ItTEA)
isLessThan
,isLessThanOrEqualTo
,isGreaterThan
,isGreaterThanOrEqualTo
&arrayContains
are all marked@NotNull
for the values. See example:Related Issues
fixes #12003
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?