feat(auth, web): migrate web to js_interop to be compatible with WASM #12145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exaby73
suggested changes
Jan 17, 2024
packages/firebase_auth/firebase_auth_web/lib/src/firebase_auth_web_user.dart
Outdated
Show resolved
Hide resolved
exaby73
approved these changes
Jan 17, 2024
russellwheatley
approved these changes
Jan 17, 2024
Comment on lines
+155
to
+156
| Future<void> linkWithRedirect(AuthProvider provider) => | ||
| auth_interop.linkWithRedirect(jsObject, provider.jsObject).toDart; |
There was a problem hiding this comment.
Suggested change
| Future<void> linkWithRedirect(AuthProvider provider) => | |
| auth_interop.linkWithRedirect(jsObject, provider.jsObject).toDart; | |
| Future<void> linkWithRedirect(AuthProvider provider) => | |
| auth_interop.linkWithRedirect(jsObject, provider.jsObject).toDart as Future<void>; |
Is this correct?
There was a problem hiding this comment.
When you run .toDart, it is interpreted as Future which includes Future so casting isn't necessary
|
|
||
| /// If signed in, it refreshes the current user. | ||
| Future<void> reload() => handleThenable(jsObject.reload()); | ||
| Future<void> reload() => jsObject.reload().toDart; |
There was a problem hiding this comment.
I see as Future<void> isn't needed on other API with this type so perhaps it isn't needed like the others returning a type as opposed to void.
JishnuM
reviewed
Feb 9, 2024
| if (e.name == 'FirebaseError') { | ||
| String code = e.code ?? ''; | ||
| String message = e.message ?? ''; | ||
| if (code.startsWith('auth/')) return false; |
There was a problem hiding this comment.
Are these checks correct? In the previous version of this, the checks were
if (code == null || !code.startsWith('auth/')) return false;
if (message == null || !message.contains('Firebase')) return false;Now it is inverted to return false if the message contains Firebase, which seems wrong?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
#12027
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?