Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage, windows): getData() crash has been fixed #12185

Merged
merged 1 commit into from Jan 23, 2024

Conversation

russellwheatley
Copy link
Member

Description

Two fixes:

  1. Use the max size passed in from user instead of artifically created max_size: https://github.com/firebase/flutterfire/compare/storage-12134?expand=1#diff-cd14e729c2a123769d24deb04c095c7e5c520143b9fa4508a63797ebe890fd85R406
  2. Check that no error exists, and send result back to the user: https://github.com/firebase/flutterfire/compare/storage-12134?expand=1#diff-cd14e729c2a123769d24deb04c095c7e5c520143b9fa4508a63797ebe890fd85R414

Related Issues

fixes #12134

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley merged commit ed8c7c5 into master Jan 23, 2024
21 checks passed
@russellwheatley russellwheatley deleted the storage-12134 branch January 23, 2024 09:06
@firebase firebase locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_storage] getData crashes the application on Windows for some files
3 participants