Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core, web): fix an incompatibility with Flutter Beta that would occur when calling method on TrustedScriptURL #12274

Merged
merged 3 commits into from Feb 2, 2024

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Feb 2, 2024

Description

As per documentation:
The representation type of all JavaScript objects for extension types.

This is the supertype of all JS objects, but not other JS types, like primitives. See https://dart.dev/web/js-interop for more details on how to use JS interop.

Related Issues

closes #12242

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

…ccur when calling method on TrustedScriptURL
@Lyokone Lyokone merged commit c395da5 into master Feb 2, 2024
19 of 21 checks passed
@Lyokone Lyokone deleted the fix/12242 branch February 2, 2024 13:57
@firebase firebase locked and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [flutter_core_web] The method 'callMethod' isn't defined for the class 'TrustedScriptURL'
3 participants