Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Privacy Manifests and code sign Frameworks for Apple #12320

Closed
ChristianEdwardPadilla opened this issue Feb 12, 2024 · 14 comments · Fixed by #12665
Closed

Add Privacy Manifests and code sign Frameworks for Apple #12320

ChristianEdwardPadilla opened this issue Feb 12, 2024 · 14 comments · Fixed by #12665
Assignees
Labels
platform: ios Issues / PRs which are specifically for iOS. resolution: fixed A fix has been merged or is pending merge from a PR. type: enhancement New feature or request

Comments

@ChristianEdwardPadilla
Copy link
Contributor

Apple will be requiring apps to include more privacy-related reasoning for "third-party SDKs" in "Spring 2024": https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_data_use_in_privacy_manifests?language=objc

You can see these FlutterFire plugins included on the list of commonly used third-party SDKs here: https://developer.apple.com/support/third-party-SDK-requirements/

It's not clear if this will affect both iOS and macOS, or just iOS.

You can see examples of these manifests included in other popular Flutter plugins, for example shared_preferences: https://github.com/flutter/packages/blob/main/packages/shared_preferences/shared_preferences_foundation/darwin/Resources/PrivacyInfo.xcprivacy

@ChristianEdwardPadilla ChristianEdwardPadilla added Needs Attention This issue needs maintainer attention. type: enhancement New feature or request labels Feb 12, 2024
@danagbemava-nc danagbemava-nc added the triage Issue is currently being triaged. label Feb 13, 2024
@danagbemava-nc
Copy link

I'm not sure if it will fine if this is done for just the iOS sdk or if this will have to be done in this sdk as well.

This would apply to all the plugins in this repo. There is an issue tracking implementing this in the iOS sdk. See
firebase/firebase-ios-sdk#11490

cc @russellwheatley for further insight

@danagbemava-nc danagbemava-nc added platform: ios Issues / PRs which are specifically for iOS. and removed triage Issue is currently being triaged. Needs Attention This issue needs maintainer attention. labels Feb 13, 2024
@GJDK
Copy link

GJDK commented Feb 20, 2024

Hi Team,

Any update on this?

@Lyokone
Copy link
Contributor

Lyokone commented Feb 23, 2024

Hello, the underlying native ios SDK is planning to add privacy manifests before the mandatory date. To my understanding, you will just need to update the FlutterFire version once available to get privacy manifests added automatically.

@jamieastley
Copy link

looks like this should be unblocked now as firebase/firebase-ios-sdk#11490 was closed earlier, and privacy manifests are included as of the 10.22.0 release.

@Lyokone
Copy link
Contributor

Lyokone commented Mar 11, 2024

Closing this issue since the latest firebase_core includes 10.22.0 release

@Lyokone Lyokone closed this as completed Mar 11, 2024
@sbt-peds
Copy link

@jamieastley @Lyokone Hello. Based on firebase/firebase-ios-sdk#12238, it looks like both privacy manifest and code signing are required to fully comply with ios privacy policy, and the new firebase_core must be released for code singning, right?

@russellwheatley
Copy link
Member

@sbt-peds - thanks for sharing the link. I'll keep this open until code signing has also been completed upstream on the firebase-ios-sdk.

Please follow this link for further details: firebase/firebase-ios-sdk#12238

@russellwheatley russellwheatley changed the title Add Privacy Manifests Add Privacy Manifests and code sign Frameworks for iOS Mar 27, 2024
@russellwheatley russellwheatley changed the title Add Privacy Manifests and code sign Frameworks for iOS Add Privacy Manifests and code sign Frameworks for Apple Mar 27, 2024
@jamieastley
Copy link

@russellwheatley codesigning should be available now in 10.24.0

firebase/firebase-ios-sdk#12238 (comment)

@russellwheatley
Copy link
Member

@jamieastley - We are working on getting this updated. It isn't quite as straight forward as changing the SDK version. Hopefully, next week's release will have the update 🙏

@ChristianEdwardPadilla
Copy link
Contributor Author

Just want to flag a potential issue: while the underlying Firebase SDK includes a manifest firebase_messaging itself uses a Required Reason API, NSUserDefaults (here). I think, to be safe, that firebase_messaging should add its own privacy manifest.

@paul678
Copy link

paul678 commented Apr 17, 2024

I can confirm the above. The firebase_messaging plugin contains R.R API and it has no privacy manifest. It's also statically linked so it means it will show up as Runner when ITMS-91053 is returned.
Checking the symbols table to the runner using the plugin will show NSUserDefaults used, as soon as I remove it this will go away as expected.

Any plans to fix this issue as it's currently forcing all plugin users to create their own privacy manifest just to account for this 😢

@russellwheatley
Copy link
Member

@paul678 - thanks for the report, I'll get this updated 🙏

@russellwheatley
Copy link
Member

@paul678 - Could you explain how you were able to validate the privacy manifest appropriately? It seems to me that I need to go through app distribution process to find out if there are any issues which seems overkill 🤔

Here is the PR as it stands: #12665

@jamieastley
Copy link

jamieastley commented Apr 17, 2024

@russellwheatley there's a forever-evolving comment from the Flutter team here that has some ongoing updates around this that may help (point 2 iv.).

AFAIK there's no other easy ways to validate compliance without submitting a build, it's insane to me that this wasn't shipped in XCode prior to these requirements being enforced..

@TarekkMA TarekkMA added the resolution: fixed A fix has been merged or is pending merge from a PR. label May 2, 2024
@firebase firebase locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: ios Issues / PRs which are specifically for iOS. resolution: fixed A fix has been merged or is pending merge from a PR. type: enhancement New feature or request
Projects
None yet
9 participants