fix(storage): Task.cancel() method wasn't properly updating task.snapshot and cancel() wasn't working in certain conditions.
#12322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eption and make it Error state
russellwheatley
changed the title
Task.cancel() method was always returning falseTask.cancel() method was always returning false for Android and iOS.
russellwheatley
changed the title
Task.cancel() method was always returning false for Android and iOS.Task.cancel() method wasn't properly updating task.snapshot and cancel() wasn't working in certain conditions.
# Conflicts: # tests/integration_test/firebase_storage/task_e2e.dart
Lyokone
approved these changes
Feb 22, 2024
exaby73
approved these changes
Feb 22, 2024
This was referenced Feb 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reinstated
cancel()tests in our integration tests to demonstrate it is working.Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?