Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(auth, web): update error handling to ensure stack traces are preserved. #12392

Merged
merged 5 commits into from Feb 28, 2024

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Feb 26, 2024

Description

This updates all API that return a Future of some type. At a later date, we can think about updating Stream exception handling as well.

Related Issues

closes #9889

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley merged commit 280dcb3 into master Feb 28, 2024
22 checks passed
@russellwheatley russellwheatley deleted the auth-9889 branch February 28, 2024 12:18
@firebase firebase locked and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update firebase_auth_web to use _flutterfire_internals for error handling
3 participants