fix(remote_config): fixing an issue that could cause duplicate listeners on hot restart #12545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested
|
TarekkMA
force-pushed
the
remote-config-12539
branch
from
c2b3968
to
d5b7812
Compare
Lyokone
reviewed
Mar 29, 2024
| @@ -291,7 +301,9 @@ - (NSString *_Nonnull)flutterChannelName { | |||
| } | |||
|
|
|||
| - (FlutterError *_Nullable)onCancelWithArguments:(id _Nullable)arguments { | |||
| NSString *appName = (NSString *)arguments; | |||
| NSString *appName = (NSString *)arguments[@"appName"]; | |||
There was a problem hiding this comment.
Was the previous appName not in arguments and it was an issue?
There was a problem hiding this comment.
This and the listenerMap wasn't initialized on init
TarekkMA
changed the title
Lyokone
approved these changes
Mar 29, 2024
LocLt-Mobile
pushed a commit
to guide-inc-org/guide-flutter_fire
that referenced
this pull request
Apr 5, 2024
…ers on hot restart (firebase#12545) * fix(remote_config, android): Fix listener cleanup on hot restart. * fix: implement clean up of listeners on apple side * chore: apple setup for example app * fix(remote_config, ios): clean listeners on hot restart * chore: formatting --------- Co-authored-by: russellwheatley <russellwheatley85@gmail.com>
LocLt-Mobile
pushed a commit
to guide-inc-org/guide-flutter_fire
that referenced
this pull request
Apr 5, 2024
…ers on hot restart (firebase#12545) * fix(remote_config, android): Fix listener cleanup on hot restart. * fix: implement clean up of listeners on apple side * chore: apple setup for example app * fix(remote_config, ios): clean listeners on hot restart * chore: formatting --------- Co-authored-by: russellwheatley <russellwheatley85@gmail.com>
LocLt-Mobile
pushed a commit
to guide-inc-org/guide-flutter_fire
that referenced
this pull request
Apr 5, 2024
…ers on hot restart (firebase#12545) * fix(remote_config, android): Fix listener cleanup on hot restart. * fix: implement clean up of listeners on apple side * chore: apple setup for example app * fix(remote_config, ios): clean listeners on hot restart * chore: formatting --------- Co-authored-by: russellwheatley <russellwheatley85@gmail.com>
LocLt-Mobile
pushed a commit
to guide-inc-org/guide-flutter_fire
that referenced
this pull request
Apr 5, 2024
…ers on hot restart (firebase#12545) * fix(remote_config, android): Fix listener cleanup on hot restart. * fix: implement clean up of listeners on apple side * chore: apple setup for example app * fix(remote_config, ios): clean listeners on hot restart * chore: formatting --------- Co-authored-by: russellwheatley <russellwheatley85@gmail.com>
LocLt-Mobile
pushed a commit
to guide-inc-org/guide-flutter_fire
that referenced
this pull request
Apr 16, 2024
…ers on hot restart (firebase#12545) * fix(remote_config, android): Fix listener cleanup on hot restart. * fix: implement clean up of listeners on apple side * chore: apple setup for example app * fix(remote_config, ios): clean listeners on hot restart * chore: formatting --------- Co-authored-by: russellwheatley <russellwheatley85@gmail.com>
LocLt-Mobile
pushed a commit
to guide-inc-org/guide-flutter_fire
that referenced
this pull request
Apr 16, 2024
…ers on hot restart (firebase#12545) * fix(remote_config, android): Fix listener cleanup on hot restart. * fix: implement clean up of listeners on apple side * chore: apple setup for example app * fix(remote_config, ios): clean listeners on hot restart * chore: formatting --------- Co-authored-by: russellwheatley <russellwheatley85@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes: #12539
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?