Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth, web): fix an issue that could prevent Recaptcha from being properly initialized #12589

Merged
merged 1 commit into from Apr 4, 2024

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Apr 4, 2024

Description

Confirmed working locally. We cannot run in e2e tests since Recaptcha would fail since it's automatised 😓

Related Issues

closes #12587

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone merged commit 8ce9162 into master Apr 4, 2024
21 checks passed
@Lyokone Lyokone deleted the fix/12587 branch April 4, 2024 14:14
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 5, 2024
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 5, 2024
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 5, 2024
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 5, 2024
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Captcha doesn't appear when verifying phone number
3 participants