fix(web): remove remaining references to dart:html
#12601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyokone
changed the title
dart:html
1 task
TarekkMA
approved these changes
Apr 8, 2024
|
@Lyokone - it appears these references also need to be removed (according to the open issue): Other than that, it LGTM. |
exaby73
approved these changes
Apr 8, 2024
|
Still looking into cleaning this conditional import EDIT: found the doc: https://dart.dev/interop/js-interop/package-web#conditional-imports |
kevmoo
reviewed
Apr 8, 2024
|
|
||
| // Clear the children in our container so we can add an element to click | ||
| target.children.clear(); | ||
| for (int i = 0; i < target.children.length; i++) { |
There was a problem hiding this comment.
I don't think this will work. The length will reduce every call, so maybe only n/2 items will be removed.
Maybe better to do a do/while?
There was a problem hiding this comment.
I think we only have a length of 1, but maybe it's isn't the case in some places.
Updated the example app code here: #12614
LocLt-Mobile
pushed a commit
to guide-inc-org/guide-flutter_fire
that referenced
this pull request
Apr 16, 2024
* fix(web): remove remaining references to dart:html * remove conditionnal import * fix conditional import
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
closes #12597
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?