Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firebase_auth] IdTokenResult object needs to have a token constructor #5

Closed
mehmetf opened this issue Aug 21, 2019 · 2 comments
Closed

Comments

@mehmetf
Copy link
Contributor

mehmetf commented Aug 21, 2019

We have applications that implement FirebaseUser class. In order to support this use case, classes such as IdTokenResult need to be open to being constructed as opposed to having only an internal API.

I propose to add:

  IdTokenResult.fromToken(String token):
      _data = <String, String>{'token': token},
      _app = null;

to it.

@mehmetf
Copy link
Contributor Author

mehmetf commented Aug 21, 2019

I will take this issue on @collinjackson . It would also be great if you could give me super powers in this repo so I can assign issues, merge PRs etc.

@mehmetf
Copy link
Contributor Author

mehmetf commented Aug 25, 2019

The decision is to implement all classes instead of returning firebase_auth owned ones.

@mehmetf mehmetf closed this as completed Aug 25, 2019
@firebase firebase locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant