Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 [firebase_core] Bump firebase_sdk_version to 8.10.0 #7766

Closed
diegog-sf opened this issue Jan 3, 2022 · 3 comments 路 Fixed by #7775
Closed

馃悰 [firebase_core] Bump firebase_sdk_version to 8.10.0 #7766

diegog-sf opened this issue Jan 3, 2022 · 3 comments 路 Fixed by #7775
Assignees
Labels
plugin: core resolution: fixed A fix has been merged or is pending merge from a PR. type: bug Something isn't working

Comments

@diegog-sf
Copy link

Bug report

Describe the bug
There was a bug on the FirebaseDynamicLinks iOS SDK that made long links being detected as short ones and the fix was released on FirebaseDynamicLinks 8.10.0. I was hoping if you could bump the firebase_sdk_version defined in firebase_core so I can use that fix.

Steps to reproduce

Dynamic links error

  1. Create a long link as per firebase docs I think only adding the url param is enough
  2. Call FirebaseDynamicLinks.instance.getDynamicLink(url)
  3. Null is returned

Expected behavior

Function should return PendingDynamicLinkData

Sample project

Providing a minimal example project which demonstrates the bug in isolation from your main App greatly enhances the chance of a timely fix.
Please link to the public repository URL.


Additional context

Add any other context about the problem here.


Flutter doctor

Run flutter doctor and paste the output below:

Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[鉁揮 Flutter (Channel stable, 2.8.1, on macOS 12.0.1 21A559 darwin-x64, locale en-MX)
[鉁揮 Android toolchain - develop for Android devices (Android SDK version 32.0.0-rc1)
[鉁揮 Xcode - develop for iOS and macOS (Xcode 13.2.1)
[鉁揮 Chrome - develop for the web
[鉁揮 Android Studio (version 2020.3)
[鉁揮 VS Code (version 1.63.2)
[鉁揮 Connected device (4 available)
    ! Error: Diego's iPhone Xs is busy: Preparing the watch for development via Diego's iPhone Xs. Xcode will continue when Diego's iPhone Xs is finished. (code -10)


Flutter dependencies

Run flutter pub deps -- --style=compact and paste the output below:

Click To Expand
Dart SDK 2.15.1
Flutter SDK 2.8.1
-------- 7.11.2

dependencies:
- adobe_mobile_sdk 0.4.0 [flutter json_serializable]
- another_flushbar 1.10.28 [flutter]
- app_settings 4.1.1 [flutter]
- barcode_widget 2.0.1 [barcode flutter]
- ble_state_plugin 0.1.0 [flutter]
- brightness_volume 1.0.3 [flutter]
- cached_network_image 3.2.0 [flutter flutter_cache_manager octo_image cached_network_image_platform_interface cached_network_image_web]
- clock 1.1.0
- collection 1.15.0
- connectivity 3.0.6 [flutter meta connectivity_platform_interface connectivity_macos connectivity_for_web]
- crypto 3.0.1 [collection typed_data]
- cupertino_icons 1.0.4
- device_calendar 4.0.1 [flutter meta collection sprintf timezone flutter_native_timezone]
- device_info 2.0.3 [flutter device_info_platform_interface]
- devicelocale 0.5.0 [flutter flutter_web_plugins]
- dio 4.0.4 [http_parser path]
- disk_space 0.2.1 [flutter]
- encrypt 5.0.1 [args asn1lib clock collection crypto pointycastle]
- equatable 2.0.3 [collection meta]
- firebase_analytics 9.0.4 [firebase_analytics_platform_interface firebase_analytics_web firebase_core firebase_core_platform_interface flutter]
- firebase_core 1.10.6 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_crashlytics 2.4.4 [firebase_core firebase_core_platform_interface firebase_crashlytics_platform_interface flutter stack_trace]
- firebase_dynamic_links 4.0.3 [firebase_core firebase_core_platform_interface firebase_dynamic_links_platform_interface flutter meta plugin_platform_interface]
- firebase_messaging 11.2.4 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta]
- firebase_performance 0.8.0+3 [firebase_core firebase_core_platform_interface firebase_performance_platform_interface firebase_performance_web flutter]
- firebase_remote_config 1.0.3 [firebase_core firebase_core_platform_interface firebase_remote_config_platform_interface firebase_remote_config_web flutter]
- flare_flutter 3.0.2 [collection flutter meta]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]
- flutter_appauth 2.2.0 [flutter flutter_appauth_platform_interface]
- flutter_bloc 8.0.0 [flutter bloc provider]
- flutter_date_pickers 0.2.7 [flutter intl flutter_localizations]
- flutter_dotenv 5.0.2 [flutter]
- flutter_localizations 0.0.0 [flutter intl characters clock collection meta path typed_data vector_math]
- flutter_platform_widgets 1.12.0 [flutter]
- flutter_secure_storage 5.0.2 [meta flutter flutter_secure_storage_linux flutter_secure_storage_macos flutter_secure_storage_platform_interface flutter_secure_storage_web flutter_secure_storage_windows]
- flutter_staggered_grid_view 0.4.1 [flutter]
- flutter_svg 0.23.0+1 [flutter meta path_drawing vector_math xml]
- geocoding 2.0.1 [flutter geocoding_platform_interface]
- geolocator 8.0.1 [flutter geolocator_platform_interface geolocator_android geolocator_apple geolocator_web]
- get_it 7.2.0 [async collection]
- google_maps_flutter 2.1.1 [flutter flutter_plugin_android_lifecycle google_maps_flutter_platform_interface]
- gql 0.13.0 [collection meta source_span]
- gql_transform_link 0.2.0 [gql_exec gql_link]
- graphql 5.0.0 [meta path gql gql_exec gql_link gql_http_link gql_transform_link gql_error_link gql_dedupe_link hive normalize http collection web_socket_channel stream_channel rxdart uuid]
- in_app_review 2.0.3 [flutter in_app_review_platform_interface]
- indigo_components 3.6.0 [flutter flutter_html scrollable_positioned_list intl quiver cached_network_image shimmer flutter_svg flare_flutter flutter_cache_manager flutter_i18n rxdart]
- intl 0.17.0 [clock path]
- json_annotation 4.1.0 [meta]
- launch_review 3.0.1 [flutter]
- legic_mobile_sdk 0.3.2 [flutter]
- libphonenumber 2.0.2 [flutter meta]
- local_auth 1.1.9 [flutter flutter_plugin_android_lifecycle intl meta platform]
- location_permissions 4.0.1 [flutter meta]
- logging 1.0.2
- notification_permissions 0.6.1 [flutter]
- package_info 2.0.2 [flutter]
- palette_generator 0.3.2 [collection flutter path]
- path_provider 2.0.8 [flutter path_provider_android path_provider_ios path_provider_linux path_provider_macos path_provider_platform_interface path_provider_windows]
- percent_indicator 3.4.0 [flutter]
- provider 6.0.1 [collection flutter nested]
- qr_flutter 4.0.0 [flutter qr]
- retry 3.1.0
- rive 0.7.33 [collection flutter graphs http meta]
- rxdart 0.26.0
- safe_device 1.0.9 [flutter trust_location]
- scrollable_positioned_list 0.2.3 [flutter collection]
- shape_sdk 0.3.2 [flutter quiver]
- share 2.0.4 [meta mime flutter]
- shared_preferences 2.0.11 [flutter meta shared_preferences_android shared_preferences_ios shared_preferences_linux shared_preferences_macos shared_preferences_platform_interface shared_preferences_web shared_preferences_windows]
- sprintf 6.0.0
- timezone 0.8.0 [path]
- tuple 2.0.0 [quiver]
- tutorial_coach_mark 1.2.1 [flutter]
- url_launcher 6.0.17 [flutter meta url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows]
- uuid 3.0.5 [crypto]
- version 2.0.0
- video_player 2.2.10 [flutter meta video_player_platform_interface video_player_web html]
- webview_flutter 2.8.0 [flutter webview_flutter_android webview_flutter_platform_interface webview_flutter_wkwebview]

dev dependencies:
- args 2.3.0
- bloc_test 9.0.1 [bloc diff_match_patch meta mocktail test]
- build_runner 2.1.7 [args async analyzer build build_config build_daemon build_resolvers build_runner_core code_builder collection crypto dart_style frontend_server_client glob graphs http_multi_server io js logging meta mime package_config path pool pub_semver pubspec_parse shelf shelf_web_socket stack_trace stream_transform timing watcher web_socket_channel yaml]
- build_test 2.1.5 [async build build_config build_resolvers crypto glob html logging matcher package_config path stream_transform test test_core watcher]
- dart_style 2.1.1 [analyzer args path pub_semver source_span]
- fake_async 1.2.0 [clock collection]
- file 6.1.2 [meta path]
- flutter_driver 0.0.0 [file flutter flutter_test fuchsia_remote_debug_protocol path meta vm_service webdriver archive async boolean_selector characters charcode clock collection crypto matcher platform process source_span stack_trace stream_channel string_scanner sync_http term_glyph test_api typed_data vector_math]
- flutter_gherkin 2.0.0 [flutter flutter_test flutter_driver meta gherkin]
- flutter_lints 1.0.4 [lints]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]
- gherkin 2.0.8 [path matcher collection]
- glob 2.0.2 [async collection file path string_scanner]
- gql_build 0.2.0 [analyzer build built_collection built_value built_value_generator code_builder dart_style glob gql gql_code_builder path yaml]
- gql_exec 0.3.0 [collection meta gql]
- integration_test 0.0.0 [flutter flutter_driver flutter_test path vm_service archive async boolean_selector characters charcode clock collection crypto fake_async file matcher meta source_span stack_trace stream_channel string_scanner sync_http term_glyph test_api typed_data vector_math webdriver]
- json_serializable 4.1.4 [analyzer build build_config collection json_annotation meta path source_gen]
- mobile_indigo_tools 0.1.2 [args jwt_decoder http intl logging oauth2 retry uuid xml]
- mocktail 0.2.0 [collection matcher test]
- path 1.8.0
- recase 4.0.0
- test 1.17.12 [analyzer async boolean_selector collection coverage http_multi_server io js node_preamble package_config path pedantic pool shelf shelf_packages_handler shelf_static shelf_web_socket source_span stack_trace stream_channel typed_data web_socket_channel webkit_inspection_protocol yaml test_api test_core]
- yaml 3.1.0 [collection source_span string_scanner]

transitive dependencies:
- _fe_analyzer_shared 22.0.0 [meta]
- analyzer 1.7.2 [_fe_analyzer_shared cli_util collection convert crypto glob meta package_config path pub_semver source_span watcher yaml pedantic]
- archive 3.1.6 [crypto path]
- asn1lib 1.0.3
- async 2.8.2 [collection meta]
- barcode 2.1.0 [meta qr]
- bloc 8.0.1 [meta]
- boolean_selector 2.1.0 [source_span string_scanner]
- build 2.2.1 [analyzer async convert crypto glob logging meta path]
- build_config 1.0.0 [checked_yaml json_annotation path pubspec_parse yaml]
- build_daemon 3.0.1 [built_collection built_value http_multi_server logging path pool shelf shelf_web_socket stream_transform watcher web_socket_channel]
- build_resolvers 2.0.4 [analyzer async build crypto graphs logging path package_config pool pub_semver stream_transform yaml]
- build_runner_core 7.2.2 [async build build_config build_resolvers collection convert crypto glob graphs json_annotation logging meta path package_config pool timing watcher yaml]
- built_collection 5.1.1
- built_value 8.1.3 [built_collection collection fixnum meta]
- built_value_generator 8.1.1 [analyzer build build_config built_collection built_value source_gen quiver]
- cached_network_image_platform_interface 1.0.0 [flutter flutter_cache_manager]
- cached_network_image_web 1.0.1 [flutter flutter_cache_manager cached_network_image_platform_interface]
- characters 1.2.0
- charcode 1.3.1
- checked_yaml 2.0.1 [json_annotation source_span yaml]
- chewie 1.1.0 [cupertino_icons flutter video_player wakelock]
- chewie_audio 1.2.0 [cupertino_icons flutter video_player]
- cli_util 0.3.5 [meta path]
- code_builder 4.1.0 [built_collection built_value collection matcher meta]
- connectivity_for_web 0.4.0+1 [connectivity_platform_interface flutter_web_plugins flutter]
- connectivity_macos 0.2.1+2 [flutter connectivity_platform_interface]
- connectivity_platform_interface 2.0.1 [flutter meta plugin_platform_interface]
- convert 3.0.1 [typed_data]
- coverage 1.0.3 [args logging package_config path source_maps stack_trace vm_service]
- csslib 0.17.1 [source_span]
- device_info_platform_interface 2.0.1 [flutter meta plugin_platform_interface]
- diff_match_patch 0.4.1
- ffi 1.1.2
- firebase 9.0.2 [http http_parser js]
- firebase_analytics_platform_interface 3.0.3 [firebase_core flutter meta plugin_platform_interface]
- firebase_analytics_web 0.4.0+4 [firebase_analytics_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- firebase_core_platform_interface 4.2.3 [collection flutter meta plugin_platform_interface]
- firebase_core_web 1.5.3 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_crashlytics_platform_interface 3.1.11 [collection firebase_core flutter meta plugin_platform_interface]
- firebase_dynamic_links_platform_interface 0.2.0+3 [firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_platform_interface 3.1.4 [firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_web 2.2.5 [firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins js meta]
- firebase_performance_platform_interface 0.1.0+3 [firebase_core flutter plugin_platform_interface]
- firebase_performance_web 0.1.0+3 [firebase firebase_core firebase_core_web firebase_performance_platform_interface flutter flutter_web_plugins js]
- firebase_remote_config_platform_interface 1.0.3 [firebase_core flutter meta plugin_platform_interface]
- firebase_remote_config_web 1.0.3 [firebase_core firebase_core_web firebase_remote_config_platform_interface flutter flutter_web_plugins js]
- fixnum 1.0.0
- flutter_appauth_platform_interface 4.0.0 [flutter plugin_platform_interface]
- flutter_blurhash 0.6.0 [flutter meta pedantic]
- flutter_cache_manager 3.3.0 [clock collection file flutter http path path_provider pedantic rxdart sqflite uuid]
- flutter_html 2.2.1 [html csslib flutter_layout_grid video_player chewie webview_flutter chewie_audio flutter_svg flutter_math_fork collection numerus flutter]
- flutter_i18n 0.31.0 [flutter flutter_localizations flutter_web_plugins intl yaml xml2json path toml logging]
- flutter_layout_grid 1.0.3 [flutter collection meta quiver]
- flutter_math_fork 0.5.0 [flutter flutter_svg provider meta collection tuple]
- flutter_native_timezone 2.0.0 [flutter_web_plugins flutter js]
- flutter_plugin_android_lifecycle 2.0.5 [flutter]
- flutter_secure_storage_linux 1.1.0 [flutter flutter_secure_storage_platform_interface]
- flutter_secure_storage_macos 1.1.0 [flutter flutter_secure_storage_platform_interface]
- flutter_secure_storage_platform_interface 1.0.0 [flutter plugin_platform_interface]
- flutter_secure_storage_web 1.0.2 [flutter flutter_web_plugins flutter_secure_storage_platform_interface js]
- flutter_secure_storage_windows 1.1.2 [flutter flutter_secure_storage_platform_interface]
- flutter_web_plugins 0.0.0 [flutter js characters collection meta typed_data vector_math]
- frontend_server_client 2.1.2 [async path]
- fuchsia_remote_debug_protocol 0.0.0 [process vm_service file meta path platform]
- geocoding_platform_interface 2.0.1 [flutter meta plugin_platform_interface]
- geolocator_android 3.0.1 [flutter geolocator_platform_interface]
- geolocator_apple 2.0.0+2 [flutter geolocator_platform_interface]
- geolocator_platform_interface 3.0.1 [flutter plugin_platform_interface vector_math meta]
- geolocator_web 2.1.1 [flutter flutter_web_plugins geolocator_platform_interface]
- google_maps_flutter_platform_interface 2.1.3 [collection flutter meta plugin_platform_interface stream_transform]
- gql_code_builder 0.2.0 [analyzer built_collection built_value code_builder collection gql gql_exec path recase]
- gql_dedupe_link 2.0.0 [meta gql_exec gql_link async]
- gql_error_link 0.2.0 [async gql_exec gql_link meta]
- gql_http_link 0.4.0 [meta gql gql_exec gql_link http http_parser]
- gql_link 0.4.0 [meta gql gql_exec]
- graphs 2.1.0 [collection]
- hive 2.0.5 [meta crypto]
- html 0.15.0 [csslib source_span]
- http 0.13.4 [async http_parser meta path]
- http_multi_server 3.0.1 [async]
- http_parser 4.0.0 [charcode collection source_span string_scanner typed_data]
- in_app_review_platform_interface 2.0.2 [flutter url_launcher plugin_platform_interface platform]
- io 1.0.3 [meta path string_scanner]
- js 0.6.3
- jwt_decoder 2.0.1
- lints 1.0.1
- matcher 0.12.11 [stack_trace]
- meta 1.7.0
- mime 1.0.1
- nested 1.0.0 [flutter]
- node_preamble 2.0.1
- normalize 0.5.5 [gql collection]
- numerus 1.1.1
- oauth2 2.0.0 [collection crypto http http_parser]
- octo_image 1.0.1 [flutter flutter_blurhash]
- package_config 2.0.2 [path]
- path_drawing 0.5.1+1 [vector_math meta path_parsing flutter]
- path_parsing 0.2.1 [vector_math meta]
- path_provider_android 2.0.11 [flutter path_provider_platform_interface]
- path_provider_ios 2.0.7 [flutter path_provider_platform_interface]
- path_provider_linux 2.1.4 [ffi flutter meta path path_provider_platform_interface xdg_directories]
- path_provider_macos 2.0.4 [flutter meta path_provider_platform_interface]
- path_provider_platform_interface 2.0.1 [flutter meta platform plugin_platform_interface]
- path_provider_windows 2.0.4 [ffi flutter meta path path_provider_platform_interface win32]
- pedantic 1.11.1
- petitparser 4.4.0 [meta]
- platform 3.0.2
- plugin_platform_interface 2.0.2 [meta]
- pointycastle 3.4.0 [collection convert js]
- pool 1.5.0 [async stack_trace]
- process 4.2.4 [file path platform]
- pub_semver 2.1.0 [collection meta]
- pubspec_parse 1.1.0 [checked_yaml collection json_annotation pub_semver yaml]
- qr 2.1.0 [meta]
- quiver 3.0.1+1 [matcher]
- shared_preferences_android 2.0.9 [flutter meta shared_preferences_platform_interface]
- shared_preferences_ios 2.0.8 [flutter meta shared_preferences_platform_interface]
- shared_preferences_linux 2.0.3 [file flutter meta path path_provider_linux shared_preferences_platform_interface]
- shared_preferences_macos 2.0.2 [flutter shared_preferences_platform_interface]
- shared_preferences_platform_interface 2.0.0 [flutter]
- shared_preferences_web 2.0.2 [flutter flutter_web_plugins meta shared_preferences_platform_interface]
- shared_preferences_windows 2.0.3 [file flutter meta path path_provider_platform_interface path_provider_windows shared_preferences_platform_interface]
- shelf 1.2.0 [async collection http_parser path stack_trace stream_channel]
- shelf_packages_handler 3.0.0 [path shelf shelf_static]
- shelf_static 1.1.0 [convert http_parser mime path shelf]
- shelf_web_socket 1.0.1 [shelf stream_channel web_socket_channel]
- shimmer 2.0.0 [flutter]
- sky_engine 0.0.99
- source_gen 1.0.3 [analyzer async build dart_style glob meta path pedantic source_span yaml]
- source_map_stack_trace 2.1.0 [path stack_trace source_maps]
- source_maps 0.10.10 [source_span]
- source_span 1.8.1 [collection path term_glyph]
- sqflite 2.0.1 [flutter sqflite_common path]
- sqflite_common 2.1.0 [synchronized path meta]
- stack_trace 1.10.0 [path]
- stream_channel 2.1.0 [async]
- stream_transform 2.0.0
- string_scanner 1.1.0 [charcode source_span]
- sync_http 0.3.0
- synchronized 3.0.0
- term_glyph 1.2.0
- test_api 0.4.3 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- test_core 0.4.2 [analyzer async args boolean_selector collection coverage frontend_server_client glob io meta package_config path pedantic pool source_map_stack_trace source_maps source_span stack_trace stream_channel vm_service yaml matcher test_api]
- timing 1.0.0 [json_annotation]
- toml 0.11.0 [meta petitparser quiver]
- trust_location 2.0.13 [flutter]
- typed_data 1.3.0 [collection]
- url_launcher_android 6.0.13 [flutter meta url_launcher_platform_interface]
- url_launcher_ios 6.0.13 [flutter meta url_launcher_platform_interface]
- url_launcher_linux 2.0.2 [flutter]
- url_launcher_macos 2.0.2 [flutter]
- url_launcher_platform_interface 2.0.4 [flutter plugin_platform_interface]
- url_launcher_web 2.0.5 [flutter flutter_web_plugins meta url_launcher_platform_interface]
- url_launcher_windows 2.0.2 [flutter]
- vector_math 2.1.1
- video_player_platform_interface 5.0.0 [flutter plugin_platform_interface]
- video_player_web 2.0.5 [flutter flutter_web_plugins meta pedantic video_player_platform_interface]
- vm_service 7.3.0
- wakelock 0.5.6 [flutter meta wakelock_macos wakelock_platform_interface wakelock_web wakelock_windows]
- wakelock_macos 0.4.0 [flutter flutter_web_plugins wakelock_platform_interface]
- wakelock_platform_interface 0.3.0 [flutter meta]
- wakelock_web 0.4.0 [flutter flutter_web_plugins js wakelock_platform_interface]
- wakelock_windows 0.2.0 [flutter wakelock_platform_interface win32]
- watcher 1.0.1 [async path]
- web_socket_channel 2.1.0 [async crypto stream_channel]
- webdriver 3.0.0 [archive matcher path stack_trace sync_http]
- webkit_inspection_protocol 1.0.0 [logging]
- webview_flutter_android 2.8.2 [flutter webview_flutter_platform_interface]
- webview_flutter_platform_interface 1.8.0 [flutter plugin_platform_interface]
- webview_flutter_wkwebview 2.7.1 [flutter webview_flutter_platform_interface]
- win32 2.3.3 [ffi]
- xdg_directories 0.2.0 [meta path process]
- xml 5.3.1 [collection meta petitparser]
- xml2json 5.3.2 [xml]

@diegog-sf diegog-sf added Needs Attention This issue needs maintainer attention. type: bug Something isn't working labels Jan 3, 2022
@diegog-sf diegog-sf changed the title 馃悰 [PLUGIN_NAME_HERE] Your issue title here 馃悰 [firebase_core] Bump firebase_sdk_version to 8.10.0 Jan 3, 2022
@maheshmnj maheshmnj added the triage Issue is currently being triaged. label Jan 4, 2022
@maheshmnj
Copy link
Member

maheshmnj commented Jan 4, 2022

Hi @diegog-sf, Thanks for filing the issue. I am unable to reproduce the issue.
running this on ios does return a valid deeplink.

final longLink = 'https://testtriage.page.link/?link=https://testtriage.page.link/helloworld&apn=com.sample.triage&isi=12345665619&ibi=com.sample.triage&imv=0&cid=4852342424011841714&_icp=1';
final PendingDynamicLinkData? initialLink =
   await FirebaseDynamicLinks.instance.getDynamicLink(Uri.parse(longLink));

I am running the dynamiclinks sample app
pubspec.yaml

  firebase_core: ^1.10.6
  firebase_dynamic_links: ^4.0.3
  url_launcher: ^6.0.17

Let me know if I am missing anything.

@maheshmnj maheshmnj added blocked: customer-response Waiting for customer response, e.g. more information was requested. and removed Needs Attention This issue needs maintainer attention. labels Jan 4, 2022
@darshankawar darshankawar added plugin: core resolution: fixed A fix has been merged or is pending merge from a PR. and removed blocked: customer-response Waiting for customer response, e.g. more information was requested. triage Issue is currently being triaged. labels Jan 5, 2022
@diegog-sf
Copy link
Author

Thanks for looking into it @maheshmnj, when running from xcode I can see that matchesShortLinkFormat is true and that code is executed. I just tried to recreate the issue and it seems its no longer happening.
At the time the issue was that resolveShortLink didn't returned the deep_link_id param as shown in the debugger, which was causing the dynamicLink url to return null.

Screen Shot 2022-01-05 at 1 18 05 p m

@diegog-sf
Copy link
Author

Just tested again and it seems that the issue is present on some links while running integration tests, honestly don't know why but i'll just wait for the PR to get merged

@firebase firebase locked and limited conversation to collaborators Feb 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
plugin: core resolution: fixed A fix has been merged or is pending merge from a PR. type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants