Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [cloud_firestore: ^3.1.12] Listener snapshot data only contains the updated value after a Firestore.update when offline on Android. #8496

Closed
edfast opened this issue Apr 21, 2022 · 11 comments · Fixed by #8617
Labels
platform: android Issues / PRs which are specifically for Android. plugin: cloud_firestore resolution: fixed A fix has been merged or is pending merge from a PR. type: bug Something isn't working

Comments

@edfast
Copy link

edfast commented Apr 21, 2022

Bug report

I'm working on a Flutter project and have problems with Firestore update. When updating data in nested maps I only get the updated data back, not the whole document. This only happens on Android being offline. This is the issue
From the release notes it seems that this issue has been fixed in Cloud Firestore 24.1.0 so the fix should be included in BoM 29.3.1 which includes Cloud Firestore 24.1.1.
I have also tried to downgrade to 29.0.3 as recommended by @dconeybe in the issue above but can't get rid of the bug.
I declared the BoM in android/app/build.gradle but I've also included the Flutter dependency "cloud_firestore: ^3.1.12" in Pubspec.yaml.
Is there a way to make sure that I'm actually using Cloud Firestore 24.1.1?
Could it be that the Flutter plugin is using another version of Cloud Firestore and overrides the BoM?

Steps to reproduce:

The same steps to reproduce as in this issue

Relevant Code:

void submitUpdate(Map<String, dynamic> updates) {
    Map<String, dynamic> _updates = {
      "lastUpdated": DateTime.now().millisecondsSinceEpoch
    };
    _updates.addAll(updates);

    FirebaseFirestore.instance.doc(_ref).update(_updates);
  }
  

Then the snapshot data in the listener only contains the updated value instead of the whole document.

FirebaseFirestore.instance
        .doc(path)
        .snapshots()
        .listen((DocumentSnapshot snapshot) {
      if (snapshot.exists && snapshot.data() != null) {
        _activeWorkout.sink.add(ActiveWorkout.fromJSON(snapshot.data()));

Expected behavior

I expect to receive the whole document with the updated value in the listener and not just the updated attribute.

Flutter doctor

Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.10.5, on macOS 12.3.1 21E258 darwin-arm, locale en-SE)
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.1)
[✓] VS Code (version 1.66.2)
[✓] Connected device (2 available)
[✓] HTTP Host Availability

• No issues found!

Flutter dependencies

Click To Expand
Dart SDK 2.16.2
Flutter SDK 2.10.5
strengthlog2 5.0+500009

dependencies:
- audioplayers 0.20.1 [uuid path_provider http flutter flutter_web_plugins]
- cloud_firestore 3.1.12 [cloud_firestore_platform_interface cloud_firestore_web collection firebase_core firebase_core_platform_interface flutter meta]
- cloud_functions 2.0.0 [cloud_functions_platform_interface cloud_functions_web firebase_core firebase_core_platform_interface flutter]
- csv 5.0.1
- cupertino_icons 1.0.4
- firebase_analytics 9.1.5 [firebase_analytics_platform_interface firebase_analytics_web firebase_core firebase_core_platform_interface flutter]
- firebase_auth 1.4.1 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_core 1.14.1 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_crashlytics 2.6.2 [firebase_core firebase_core_platform_interface firebase_crashlytics_platform_interface flutter stack_trace]
- firebase_messaging 11.2.13 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta]
- firebase_storage 10.2.12 [firebase_core firebase_core_platform_interface firebase_storage_platform_interface firebase_storage_web flutter]
- flutter 0.0.0 [characters collection material_color_utilities meta typed_data vector_math sky_engine]
- flutter_colorpicker 0.6.1 [flutter]
- flutter_facebook_auth 3.5.7 [flutter flutter_facebook_auth_platform_interface flutter_facebook_auth_web]
- flutter_html 2.2.1 [html csslib flutter_layout_grid video_player chewie webview_flutter chewie_audio flutter_svg flutter_math_fork collection numerus flutter]
- flutter_inapp_purchase 5.1.2 [flutter http meta platform]
- flutter_keyboard_visibility 5.2.0 [meta flutter_keyboard_visibility_platform_interface flutter_keyboard_visibility_web flutter]
- flutter_local_notifications 9.4.0 [clock flutter flutter_local_notifications_linux flutter_local_notifications_platform_interface timezone]
- flutter_localizations 0.0.0 [flutter intl characters clock collection material_color_utilities meta path typed_data vector_math]
- flutter_slidable 1.2.0 [flutter]
- flutter_speed_dial 3.0.5 [flutter]
- flutter_svg 0.22.0 [flutter meta path_drawing vector_math xml]
- google_sign_in 5.2.4 [flutter google_sign_in_platform_interface google_sign_in_web]
- health_kit_reporter 1.5.2 [flutter]
- image_cropper 1.5.0 [flutter]
- image_gallery_saver 1.7.1 [flutter]
- image_picker 0.8.4+11 [flutter flutter_plugin_android_lifecycle image_picker_for_web image_picker_platform_interface]
- in_app_purchase 0.5.2 [flutter json_annotation meta collection]
- intl 0.17.0 [clock path]
- lottie 1.2.2 [archive flutter path vector_math]
- material_design_icons_flutter 5.0.6595 [flutter]
- package_info 2.0.2 [flutter]
- path_provider 2.0.9 [flutter path_provider_android path_provider_ios path_provider_linux path_provider_macos path_provider_platform_interface path_provider_windows]
- percent_indicator 3.4.0 [flutter]
- permission_handler 9.2.0 [flutter meta permission_handler_android permission_handler_apple permission_handler_windows permission_handler_platform_interface]
- provider 6.0.2 [collection flutter nested]
- rive 0.8.4 [collection flutter graphs http meta]
- rxdart 0.27.3
- screenshot 1.2.3 [flutter]
- share_plus 4.0.2 [meta mime flutter share_plus_platform_interface share_plus_linux share_plus_macos share_plus_windows share_plus_web]
- shared_preferences 2.0.13 [flutter shared_preferences_android shared_preferences_ios shared_preferences_linux shared_preferences_macos shared_preferences_platform_interface shared_preferences_web shared_preferences_windows]
- sign_in_with_apple 3.3.0 [flutter meta sign_in_with_apple_platform_interface sign_in_with_apple_web]
- smooth_page_indicator 1.0.0+2 [flutter]
- strengthlog_business_logic 0.0.1 [flutter cloud_firestore rxdart intl flutter_svg cloud_functions firebase_analytics firebase_auth syncfusion_flutter_core syncfusion_flutter_datepicker]
- syncfusion_flutter_charts 19.4.55 [flutter intl vector_math syncfusion_flutter_core]
- syncfusion_flutter_sliders 19.4.55 [flutter intl syncfusion_flutter_core]
- table_calendar 3.0.4 [flutter intl simple_gesture_detector]
- url_launcher 6.0.20 [flutter url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows]
- wakelock 0.5.6 [flutter meta wakelock_macos wakelock_platform_interface wakelock_web wakelock_windows]

dev dependencies:
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher material_color_utilities meta source_span stream_channel string_scanner term_glyph typed_data]

transitive dependencies:
- archive 3.2.2 [crypto path]
- args 2.3.0
- async 2.8.2 [collection meta]
- boolean_selector 2.1.0 [source_span string_scanner]
- characters 1.2.0
- charcode 1.3.1
- chewie 1.1.0 [cupertino_icons flutter video_player wakelock]
- chewie_audio 1.3.0 [cupertino_icons flutter video_player]
- clock 1.1.0
- cloud_firestore_platform_interface 5.5.3 [collection firebase_core flutter meta plugin_platform_interface]
- cloud_firestore_web 2.6.12 [cloud_firestore_platform_interface collection firebase_core firebase_core_web flutter flutter_web_plugins js]
- cloud_functions_platform_interface 5.1.3 [firebase_core flutter meta plugin_platform_interface]
- cloud_functions_web 4.2.11 [cloud_functions_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- collection 1.15.0
- cross_file 0.3.2 [flutter js meta]
- crypto 3.0.1 [collection typed_data]
- csslib 0.17.1 [source_span]
- dbus 0.7.2 [args ffi meta xml]
- fake_async 1.2.0 [clock collection]
- ffi 1.1.2
- file 6.1.2 [meta path]
- firebase_analytics_platform_interface 3.1.3 [firebase_core flutter meta plugin_platform_interface]
- firebase_analytics_web 0.4.0+10 [firebase_analytics_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins js]
- firebase_auth_platform_interface 4.3.1 [firebase_core flutter meta plugin_platform_interface]
- firebase_auth_web 1.3.1 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser intl js meta]
- firebase_core_platform_interface 4.2.5 [collection flutter meta plugin_platform_interface]
- firebase_core_web 1.6.2 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_crashlytics_platform_interface 3.2.3 [collection firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_platform_interface 3.2.3 [firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_web 2.2.11 [firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins js meta]
- firebase_storage_platform_interface 4.1.3 [collection firebase_core flutter meta plugin_platform_interface]
- firebase_storage_web 3.2.12 [async firebase_core firebase_core_web firebase_storage_platform_interface flutter flutter_web_plugins http js meta]
- flutter_facebook_auth_platform_interface 2.7.1 [flutter plugin_platform_interface]
- flutter_facebook_auth_web 2.6.0+2 [flutter flutter_web_plugins js flutter_facebook_auth_platform_interface]
- flutter_keyboard_visibility_platform_interface 2.0.0 [flutter meta plugin_platform_interface]
- flutter_keyboard_visibility_web 2.0.0 [flutter_keyboard_visibility_platform_interface flutter_web_plugins flutter]
- flutter_layout_grid 1.0.6 [flutter collection meta quiver]
- flutter_local_notifications_linux 0.4.2 [flutter flutter_local_notifications_platform_interface dbus path xdg_directories]
- flutter_local_notifications_platform_interface 5.0.0 [flutter plugin_platform_interface]
- flutter_math_fork 0.4.2+2 [flutter flutter_svg provider meta collection tuple]
- flutter_plugin_android_lifecycle 2.0.5 [flutter]
- flutter_web_plugins 0.0.0 [flutter js characters collection material_color_utilities meta typed_data vector_math]
- google_sign_in_platform_interface 2.1.2 [flutter quiver]
- google_sign_in_web 0.10.0+5 [flutter flutter_web_plugins google_sign_in_platform_interface js]
- graphs 2.1.0 [collection]
- html 0.15.0 [csslib source_span]
- http 0.13.4 [async http_parser meta path]
- http_parser 4.0.0 [charcode collection source_span string_scanner typed_data]
- image_picker_for_web 2.1.6 [flutter flutter_web_plugins image_picker_platform_interface]
- image_picker_platform_interface 2.4.4 [cross_file flutter http plugin_platform_interface]
- js 0.6.3
- json_annotation 4.4.0 [meta]
- matcher 0.12.11 [stack_trace]
- material_color_utilities 0.1.3
- meta 1.7.0
- mime 1.0.1
- nested 1.0.0 [flutter]
- numerus 1.1.1
- path 1.8.0
- path_drawing 0.5.1+1 [vector_math meta path_parsing flutter]
- path_parsing 0.2.1 [vector_math meta]
- path_provider_android 2.0.12 [flutter path_provider_platform_interface]
- path_provider_ios 2.0.8 [flutter path_provider_platform_interface]
- path_provider_linux 2.1.5 [ffi flutter path path_provider_platform_interface xdg_directories]
- path_provider_macos 2.0.5 [flutter path_provider_platform_interface]
- path_provider_platform_interface 2.0.3 [flutter platform plugin_platform_interface]
- path_provider_windows 2.0.5 [ffi flutter path path_provider_platform_interface win32]
- permission_handler_android 9.0.2+1 [flutter permission_handler_platform_interface]
- permission_handler_apple 9.0.3 [flutter permission_handler_platform_interface]
- permission_handler_platform_interface 3.7.0 [flutter meta plugin_platform_interface]
- permission_handler_windows 0.1.0 [flutter permission_handler_platform_interface]
- petitparser 4.4.0 [meta]
- platform 3.1.0
- plugin_platform_interface 2.1.2 [meta]
- process 4.2.4 [file path platform]
- quiver 3.0.1+1 [matcher]
- share_plus_linux 3.0.0 [share_plus_platform_interface file flutter meta url_launcher]
- share_plus_macos 3.0.0 [share_plus_platform_interface flutter]
- share_plus_platform_interface 3.0.1 [flutter meta mime plugin_platform_interface]
- share_plus_web 3.0.0 [share_plus_platform_interface url_launcher flutter flutter_web_plugins meta]
- share_plus_windows 3.0.0 [share_plus_platform_interface flutter meta url_launcher]
- shared_preferences_android 2.0.11 [flutter shared_preferences_platform_interface]
- shared_preferences_ios 2.1.0 [flutter shared_preferences_platform_interface]
- shared_preferences_linux 2.1.0 [file flutter path path_provider_linux path_provider_platform_interface shared_preferences_platform_interface]
- shared_preferences_macos 2.0.3 [flutter shared_preferences_platform_interface]
- shared_preferences_platform_interface 2.0.0 [flutter]
- shared_preferences_web 2.0.3 [flutter flutter_web_plugins shared_preferences_platform_interface]
- shared_preferences_windows 2.1.0 [file flutter path path_provider_platform_interface path_provider_windows shared_preferences_platform_interface]
- sign_in_with_apple_platform_interface 1.0.0 [flutter plugin_platform_interface meta]
- sign_in_with_apple_web 1.0.1 [flutter flutter_web_plugins sign_in_with_apple_platform_interface js]
- simple_gesture_detector 0.2.0 [flutter]
- sky_engine 0.0.99
- source_span 1.8.1 [collection path term_glyph]
- stack_trace 1.10.0 [path]
- stream_channel 2.1.0 [async]
- string_scanner 1.1.0 [charcode source_span]
- syncfusion_flutter_core 19.4.55 [vector_math flutter]
- syncfusion_flutter_datepicker 19.4.55 [flutter intl syncfusion_flutter_core]
- term_glyph 1.2.0
- test_api 0.4.8 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- timezone 0.8.0 [path]
- tuple 2.0.0 [quiver]
- typed_data 1.3.0 [collection]
- url_launcher_android 6.0.15 [flutter url_launcher_platform_interface]
- url_launcher_ios 6.0.15 [flutter url_launcher_platform_interface]
- url_launcher_linux 3.0.0 [flutter url_launcher_platform_interface]
- url_launcher_macos 3.0.0 [flutter url_launcher_platform_interface]
- url_launcher_platform_interface 2.0.5 [flutter plugin_platform_interface]
- url_launcher_web 2.0.9 [flutter flutter_web_plugins url_launcher_platform_interface]
- url_launcher_windows 3.0.0 [flutter url_launcher_platform_interface]
- uuid 3.0.6 [crypto]
- vector_math 2.1.1
- video_player 2.3.0 [flutter html video_player_android video_player_avfoundation video_player_platform_interface video_player_web]
- video_player_android 2.3.0 [flutter video_player_platform_interface]
- video_player_avfoundation 2.3.0 [flutter video_player_platform_interface]
- video_player_platform_interface 5.1.0 [flutter plugin_platform_interface]
- video_player_web 2.0.7 [flutter flutter_web_plugins video_player_platform_interface]
- wakelock_macos 0.4.0 [flutter flutter_web_plugins wakelock_platform_interface]
- wakelock_platform_interface 0.3.0 [flutter meta]
- wakelock_web 0.4.0 [flutter flutter_web_plugins js wakelock_platform_interface]
- wakelock_windows 0.2.0 [flutter wakelock_platform_interface win32]
- webview_flutter 2.8.0 [flutter webview_flutter_android webview_flutter_platform_interface webview_flutter_wkwebview]
- webview_flutter_android 2.8.3 [flutter webview_flutter_platform_interface]
- webview_flutter_platform_interface 1.8.1 [flutter plugin_platform_interface]
- webview_flutter_wkwebview 2.7.1 [flutter webview_flutter_platform_interface]
- win32 2.4.1 [ffi]
- xdg_directories 0.2.0+1 [meta path process]
- xml 5.3.1 [collection meta petitparser]```

</details>

---
@edfast edfast added Needs Attention This issue needs maintainer attention. type: bug Something isn't working labels Apr 21, 2022
@edfast edfast changed the title 🐛 [cloud_firestore: `3.1.12] 🐛 [cloud_firestore: `3.1.12] Listener snapshot data only contains the updated value after a Firestore.update when offline on Android. Apr 21, 2022
@edfast edfast changed the title 🐛 [cloud_firestore: `3.1.12] Listener snapshot data only contains the updated value after a Firestore.update when offline on Android. 🐛 [cloud_firestore: ^3.1.12] Listener snapshot data only contains the updated value after a Firestore.update when offline on Android. Apr 21, 2022
@darshankawar darshankawar added the triage Issue is currently being triaged. label Apr 22, 2022
@darshankawar
Copy link

@edfast
Is this the correct link that you mentioned above ? #3528 because it doesn't contain any steps to replicate so confirming first.

Is there a way to make sure that I'm actually using Cloud Firestore 24.1.1?
Could it be that the Flutter plugin is using another version of Cloud Firestore and overrides the BoM?

Can you provide your app and project level build.gradle ?

@darshankawar darshankawar added blocked: customer-response Waiting for customer response, e.g. more information was requested. and removed Needs Attention This issue needs maintainer attention. labels Apr 22, 2022
@edfast
Copy link
Author

edfast commented Apr 22, 2022

@edfast Is this the correct link that you mentioned above ? #3528 because it doesn't contain any steps to replicate so confirming first.

Is there a way to make sure that I'm actually using Cloud Firestore 24.1.1?
Could it be that the Flutter plugin is using another version of Cloud Firestore and overrides the BoM?

Can you provide your app and project level build.gradle ?

@darshankawar my bad! The issue I meant to refer to is in another repository so can't use hashtag to link to it here ofc. Updated the link now.

The project build.gradle:

buildscript {
    ext.kotlin_version = '1.6.10'
    repositories {
        google()
        mavenCentral()
    }

    dependencies {
        classpath 'com.android.tools.build:gradle:4.1.0'
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
        classpath 'com.google.gms:google-services:4.3.10'
    }
}

allprojects {
    repositories {
        google()
        mavenCentral()
    }
}

rootProject.buildDir = '../build'
subprojects {
    project.buildDir = "${rootProject.buildDir}/${project.name}"
}
subprojects {
    project.evaluationDependsOn(':app')
}

task clean(type: Delete) {
    delete rootProject.buildDir
}

The app build.gradle:

def localProperties = new Properties()
def localPropertiesFile = rootProject.file('local.properties')
if (localPropertiesFile.exists()) {
    localPropertiesFile.withReader('UTF-8') { reader ->
        localProperties.load(reader)
    }
}

def flutterRoot = localProperties.getProperty('flutter.sdk')
if (flutterRoot == null) {
    throw new GradleException("Flutter SDK not found. Define location with flutter.sdk in the local.properties file.")
}

def flutterVersionCode = localProperties.getProperty('flutter.versionCode')
if (flutterVersionCode == null) {
    flutterVersionCode = '1'
}

def flutterVersionName = localProperties.getProperty('flutter.versionName')
if (flutterVersionName == null) {
    flutterVersionName = '1.0'
}

apply plugin: 'com.android.application'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"
apply plugin: 'com.google.gms.google-services'

android {
    compileSdkVersion 31

    compileOptions {
        sourceCompatibility JavaVersion.VERSION_1_8
        targetCompatibility JavaVersion.VERSION_1_8
    }

    defaultConfig {
        applicationId "com.styrkelabbet.Styrkelabbet"
        minSdkVersion 23
        targetSdkVersion 31
        versionCode flutterVersionCode.toInteger()
        versionName flutterVersionName
    }

    signingConfigs {
        release {
            *Removed sensitive info*
        }
    }

    buildTypes {
        release {
            signingConfig signingConfigs.release
        }
    }
}

flutter {
    source '../..'
}

dependencies {
    // For Google Fit
    implementation 'com.google.android.gms:play-services-fitness:20.0.0'
    implementation 'com.google.android.gms:play-services-auth:19.2.0'
    // Import the BoM for the Firebase platform
    implementation platform('com.google.firebase:firebase-bom:29.3.1')
    // Misc
    implementation 'com.android.support:appcompat-v7:22.0.0'
    implementation 'com.google.firebase:firebase-messaging'
    implementation 'com.google.firebase:firebase-analytics'
}

@google-oss-bot google-oss-bot added Needs Attention This issue needs maintainer attention. and removed blocked: customer-response Waiting for customer response, e.g. more information was requested. labels Apr 22, 2022
@darshankawar
Copy link

Thanks for the update. I see that you are using :

implementation platform('com.google.firebase:firebase-bom:29.3.1'). I'll keep it open and label for the team to look into this to see if the plugin need to be bumped to latest bom.

/cc @russellwheatley

@darshankawar darshankawar added plugin: cloud_firestore platform: android Issues / PRs which are specifically for Android. and removed Needs Attention This issue needs maintainer attention. triage Issue is currently being triaged. labels Apr 25, 2022
@edfast
Copy link
Author

edfast commented Apr 25, 2022

@darshankawar Btw, what bom version of Cloud Firestore is the flutter plugin cloud_firestore version 3.1.13 using? I can't find it anywhere.
The issue that I'm having is reported to be fixed in Cloud Firestore version 24.1.0. So if you could bump to a bom that uses that version or newer I would appreciate it a lot!

Changelog: https://firebase.google.com/support/release-notes/android#firestore_v24-1-0

@russellwheatley
Copy link
Member

Hey @edfast, 3.1.13 is using the latest BOM (29.3.1), this is where the BOM is set.

@edfast
Copy link
Author

edfast commented Apr 27, 2022

@russellwheatley thanks for the clarification!
Just to make sure I got this right: The Firebase SDK version that is declared in Firebase Core is propagated to all the FlutterFire plugins?

Referring to this: https://github.com/firebase/flutterfire/blob/master/packages/cloud_firestore/cloud_firestore/android/build.gradle#L52

FYI: My colleague reached out to the Firebase support and they were able to recreate the issue and are working on a fix. I'll keep you posted if they release a fix. Would really appreciate a fast bump in Firebase core when that happens! :)

@russellwheatley
Copy link
Member

Just to make sure I got this right: The Firebase SDK version that is declared in Firebase Core is propagated to all the FlutterFire plugins?

Referring to this: https://github.com/firebase/flutterfire/blob/master/packages/cloud_firestore/cloud_firestore/android/build.gradle#L52

Yes, this is correct.

FYI: My colleague reached out to the Firebase support and they were able to recreate the issue and are working on a fix. I'll keep you posted if they release a fix. Would really appreciate a fast bump in Firebase core when that happens! :)

Perfect, we're very glad to get releases out for any fixes! Let us know 👍. Thanks 😄

@edfast
Copy link
Author

edfast commented May 9, 2022

Hello @russellwheatley! The day has come - a new release of Firebase Android SDK version has been released that should fix the issue! Can you please bump to 30.0.0 in Firebase core? 😄

@edfast
Copy link
Author

edfast commented May 9, 2022

Thanks mate, appreciate the fast response! Is there an ETA for the release?
Sorry for being pushy but it will sort out a lot of issues for us! 😅

@russellwheatley
Copy link
Member

@edfast Tomorrrow hopefully, if not, definitely at some point this week 🙏

@darshankawar darshankawar added the resolution: fixed A fix has been merged or is pending merge from a PR. label May 10, 2022
@edfast
Copy link
Author

edfast commented May 10, 2022

Hi again! I tried updating the BOM version to 30.0.0 in the top-level build.gradle (android/app/build.gradle) and the problem is gone! Is it true that specifying a BOM there overrides the Firebase SDK version declared in Firebase core?

I can't figure out if I have FlutterFire in the rootProject in the def below, from cloud_firestore/android/build.gradle.

def getRootProjectExtOrCoreProperty(name, firebaseCoreProject) {
    if (!rootProject.ext.has('FlutterFire')) return firebaseCoreProject.properties[name]
    if (!rootProject.ext.get('FlutterFire')[name]) return firebaseCoreProject.properties[name]
    return rootProject.ext.get('FlutterFire').get(name)
}

@firebase firebase locked and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: android Issues / PRs which are specifically for Android. plugin: cloud_firestore resolution: fixed A fix has been merged or is pending merge from a PR. type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants