fix(firebase_analytics): allow null
values for setDefaultEventParameters()
which removes defaults. Permissible on android and iOS.
#9135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in the linked issue,
setDefaultEventParameters
should acceptMap<String, Object?>?
.In order to reset default event parameters, you should set the corresponding key to null. In order to reset all parameters, you should pass
null
.That's what the documentation for Android and iOS says.
However, the Dart code only accepts
Map<String, Object>
according to the docs.Since this fixes a bug, this is not a breaking change.
Related Issues
Fixes #9005.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?