fix(firestore, web): change the interop to fix an issue with startAt() & endAt() when compiling with dart2js in release mode
#9246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endAt when compilating with dart2js in release mode
russellwheatley
changed the title
startAt() & endAt() when compiling with dart2js in release mode
russellwheatley
approved these changes
Jul 28, 2022
Salakar
reviewed
Jul 28, 2022
packages/cloud_firestore/cloud_firestore_web/lib/src/interop/firestore.dart
Show resolved
Hide resolved
Salakar
approved these changes
Jul 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed internally, there is an issue with dart2js compilation in release mode.
One of the workaround is to type those functions as Object.
The tests for Cloud Firestore are currently skipped, we'll bring back those tests in another PR.
Related Issues
fixes #9106
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?