fix(firestore, web): fix a query error in Flutter Web that was affecting the parsing of ancient dates #9633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the parsing of ancient dates
rrousselGit
reviewed
Sep 29, 2022
| @@ -23,8 +24,7 @@ dynamic dartify(Object? jsObject) { | |||
| return object; | |||
| } | |||
| if (util.instanceof(object, TimestampJsConstructor)) { | |||
| return DateTime.fromMillisecondsSinceEpoch( | |||
| (object as TimestampJsImpl).toMillis()); | |||
| return Timestamp((object as TimestampJsImpl).seconds, object.nanoseconds); | |||
There was a problem hiding this comment.
Does that mean what used to be decoded as a DateTime is now decoded as a Timestamp? If so, that could be a breaking change
There was a problem hiding this comment.
We were previously decoding it as follow TimestampJS => DateTime => Timestamp
Now we only do TimestampJS => Timestamp
So no breaking change :)
There was a problem hiding this comment.
I think it would also show up in the e2e tests if it was a problem
russellwheatley
approved these changes
Sep 29, 2022
Salakar
approved these changes
Oct 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of going through DateTime, which was causing errors, I'm going directly to the Timestamp class (which is the intended final class). Removing the DateTime step removes the error.
Related Issues
Fixes #7230
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?