New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloud_firestore_odm): Update ignored lints in generated files #9683
Merged
rrousselGit
merged 8 commits into
firebase:master
from
Rexios80:feature/fix-generated-odm-lints
Oct 6, 2022
Merged
fix(cloud_firestore_odm): Update ignored lints in generated files #9683
rrousselGit
merged 8 commits into
firebase:master
from
Rexios80:feature/fix-generated-odm-lints
Oct 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xpecting future contributions to follow the rule or causing a bunch more changes by enabling the lint for the whole project
…ed files is a whole big mess
Rexios80
changed the title
[cloud_firestore_odm] Fix generated odm lints
[cloud_firestore_odm] fix: generated odm lints
Oct 5, 2022
Rexios80
changed the title
[cloud_firestore_odm] fix: generated odm lints
fix(cloud_firestore_odm) generated odm lints
Oct 5, 2022
Rexios80
changed the title
fix(cloud_firestore_odm) generated odm lints
fix(cloud_firestore_odm): generated odm lints
Oct 5, 2022
rrousselGit
reviewed
Oct 6, 2022
packages/cloud_firestore_odm/cloud_firestore_odm_generator/pubspec.yaml
Outdated
Show resolved
Hide resolved
rrousselGit
reviewed
Oct 6, 2022
packages/cloud_firestore_odm/cloud_firestore_odm_generator/pubspec.yaml
Outdated
Show resolved
Hide resolved
rrousselGit
reviewed
Oct 6, 2022
packages/cloud_firestore_odm/cloud_firestore_odm_generator/pubspec.yaml
Outdated
Show resolved
Hide resolved
rrousselGit
reviewed
Oct 6, 2022
packages/cloud_firestore_odm/cloud_firestore_odm_generator/pubspec.yaml
Outdated
Show resolved
Hide resolved
rrousselGit
changed the title
fix(cloud_firestore_odm): generated odm lints
fix(cloud_firestore_odm): Update ignored lints in generated files
Oct 6, 2022
You should be able to do this without modifying the ODM by configuring your But these changes are reasonable, so I'll accept them. |
rrousselGit
approved these changes
Oct 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Lyokone
approved these changes
Oct 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes:
ignore_for_file
list:require_trailing_commas
,prefer_single_quotes
,prefer_double_quotes
,use_super_parameters
Notes:
implicit-dynamic
seems to make that impossible without more changes that are outside the scope of this PRfreezed.g.dart
was missing the import forpackage:cloud_firestore/cloud_firestore.dart
, but the analyzer didn't make that obvious since the file was excluded from analysis.cloud_firestore_odm_generator
. If you would like me to remove it just let me know.Related Issues
N/A
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?