Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even when using FirebaseOptions to create a [DEFAULT] FirebaseApp, Google Service still tries to use google_app_id. #769

Closed
harsh0893 opened this issue Dec 17, 2018 · 6 comments

Comments

@harsh0893
Copy link

Please someone provide a solution for this.

@harsh0893 harsh0893 changed the title Even when using FirebaseOptions to create a [DEFAULT] FirebaseApp, Google Service still tries to use google_app_id. This is a bug in my opinion. Even when using FirebaseOptions to create a [DEFAULT] FirebaseApp, Google Service still tries to use google_app_id. Dec 17, 2018
@samtstern
Copy link
Contributor

@harsh0893 this is currently working as intended, the Analytics SDK does not allow configuration of the App ID at runtime. However I will pass on your feedback, since this could change in the future.

P.S. please use the issue template next time!

@prilaga
Copy link

prilaga commented Jan 30, 2023

It's so cool to hardcode the keys in xml and provide them to any reverse engineer! Security is the last thing firebase provides

@thatfiredev
Copy link
Member

@OlegTarashkevich Note that those keys are not secrets, as explained in this page.

@prilaga
Copy link

prilaga commented Jan 30, 2023

@thatfiredev It's nice to have unique keys that anyone can extract and reuse as their own. Even SafetyNet won't help.

@thatfiredev
Copy link
Member

SafetyNet is being deprecated anyways, so probably not a worthy mention. But maybe PlayIntegrity?

@prilaga
Copy link

prilaga commented Feb 5, 2023

The Firebase team makes an amazing SDK.
But, unfortunately, "ignoring the problem" is the second name for this sdk team.

The problem can be solved with a resource wrapper in the Application class:
https://gist.github.com/electricbolt/423c03f09bc0303d0d5696b8beb392bd

public class App extends Application {

    private FirebaseResourcesWrapper firebaseResources;

    @Override
    public Resources getResources() {
        if (firebaseResources == null)
            firebaseResources = new FirebaseResourcesWrapper(super.getResources());
        return firebaseResources;
    }

}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants