Make ReactFireMixin browserifyable #17
Conversation
The curent build footer export won't export anything when ReactFireMixin is browserified. Replacing the build header & footer with standard UMD boilerplate will fix this and also make it usable for AMD users.
|
Thanks @insin. I'll take a look at this in a day or two. |
|
@jwngr - have you had a chance to look at this? This is being used by @insin in a reasonably high profile hacker news post - about recreating hacker news in React using reactFire, and I'm sure everyone that pulls and builds his project (https://github.com/insin/react-hn) is coming up against this error (like me ;-) thanks! |
|
@bradparks - Yup, thanks for the ping on this one. It slipped through my radar and I had forgotten about it. I need to figure out why Travis is failing and test this a bit myself, but I should have time to do that today. I'll get out a new release as soon as I'm happy with the change. P.S. Thanks for the |
|
Thanks for the contribution @insin. I'll get the Travis issues fixed in a follow-up commit and cut a new release later today. |
Make ReactFireMixin browserifyable
|
This has been released as version 0.3.0. Thanks again for the PR and nudge! |
|
Awesome! thanks dude! |
The current build footer export won't export anything when ReactFireMixin is browserified.
Replacing the build header & footer with standard UMD boilerplate will fix this and also make it usable for AMD users.