Fixed broken test suite #23
Conversation
|
Things still aren't running properly on Travis. Please don't merge yet. |
|
ack :) I'll wait for them to pass before I merge On Wed, Oct 22, 2014 at 3:47 PM, Jacob Wenger notifications@github.com
|
This fixed an issue running the test suite in Firefox
|
Changes Unknown when pulling b4909cc on jw-tests into * on master*. |
|
WOOOOOOOOOOT! Got it working! |
|
yay! On Wed, Oct 22, 2014 at 10:57 PM, Jacob Wenger notifications@github.com
|
|
Changes Unknown when pulling 86d9262 on jw-tests into * on master*. |
|
Feel free to merge this in if you are happy with it. I've got a lot more repos to update with this new system... |
| @@ -21,7 +18,7 @@ var invalidBindVars = ["", 1, true, false, [], {}, [1, 2], {a: 1}, null, undefin | |||
| /* Helper function which runs before each Jasmine test has started */ | |||
| function beforeEachHelper(done) { | |||
| // Create a new firebase ref with a new context | |||
| firebaseRef = new Firebase(demoFirebaseUrl, Firebase.Context()); | |||
| firebaseRef = new Firebase("https://tests.firebaseio.com", Firebase.Context()); | |||
There was a problem hiding this comment.
Is this a special Firebase? or just a normal one that we own?
There was a problem hiding this comment.
It's just a Firebase that Rob owns that we use in a lot of test suites. It's set to read true/write true and has no important data in it. I switched it from a demo Firebase because the Firebase client was having issues connecting to the demo Firebase for some reason. I'm going to work with Rob today to figure out why that was the case with firebaseio-demo.
There was a problem hiding this comment.
Demo has been fixed - it had some mitigation for POODLE that was causing issues with Firefox
@mimming - Due to the recent POODLE security vulnerability, Firebase dropped support for SSL v3. Unfortunately, PhantomJS uses SSLv3 so this test suite was broken. Thankfully, Travis supports running the test suite in Firefox. Locally, the tests will be run in Chrome.