Allow a callback to be passed for the cancelCallback argument to firebaseRef.on() #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…baseRef.on() Not sure how to add a test to your suite for this, but have checked it at least works locally in react-hn against the Hacker News API, which errors when attempting to load delayed comments
insin
added a commit
to insin/react-hn
that referenced
this pull request
Oct 23, 2014
Display a notificatiom to the user Vendoring a version of Reactfire which allows you to pass a cancelCallback until FirebaseExtended/reactfire#24 is merged or similar functionality is added
|
Hey @insin - I apologize for not responding to your issue or this pull request for such a long time. I'll try to be more responsive in the future. Thanks for this PR! I really like this addition and want to add it to the library. I have one requests before merging this in though. The test suite is failing in Travis because of the change you made. Can you please update these lines to include a dummy callback function ( Thanks! I'm looking forward to getting this merged in! |
jwngr
pushed a commit
that referenced
this pull request
Oct 27, 2014
Allow a callback to be passed for the cancelCallback argument to firebaseRef.on()
|
Thanks again for the PR @insin! We'll release a new version of ReactFire later this week with this change included. We may want to get a few of the other open PRs in as well. |
randytsmith
pushed a commit
to randytsmith/newspost
that referenced
this pull request
Apr 1, 2018
Display a notificatiom to the user Vendoring a version of Reactfire which allows you to pass a cancelCallback until FirebaseExtended/reactfire#24 is merged or similar functionality is added
dezine2dev
added a commit
to dezine2dev/newspost
that referenced
this pull request
Jul 4, 2018
Display a notificatiom to the user Vendoring a version of Reactfire which allows you to pass a cancelCallback until FirebaseExtended/reactfire#24 is merged or similar functionality is added
nathaniel83
added a commit
to nathaniel83/react-hacker-news
that referenced
this pull request
Oct 3, 2018
Display a notificatiom to the user Vendoring a version of Reactfire which allows you to pass a cancelCallback until FirebaseExtended/reactfire#24 is merged or similar functionality is added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds API suggested in #19
Not sure how to add a test to your suite for this, but have checked it at least works locally in react-hn against the Hacker News API, which errors when attempting to load delayed comments