Add key to the items in the array (as $id)

[puf]

This way the key can be used to identify the items in the React output and tie updates back to the correct child(). See this fiddle for an example (clicking a Todo item removes it): https://jsfiddle.net/frankvanpuffelen/s27nz1hb/

[coveralls]

Coverage increased (+0.06%) to 98.33% when pulling f098f7c on puf:puf-add-id-to-array-items into e3bbf46 on firebase:master.

[jwngr]

Thanks for the PR @puf! Have you seen the discussion in #37? I think we should go with a more fully-fledged solution here. As noted in the issue, I'd like to do something very similar to what we do with AngularFire. Most notably, your solution won't work for primitive values since setting $id on the primitive value won't actually have the effect we want.

[puf]

@jwngr quick double check here....
Case 1: array of objects; if you pass in:
firebaseRef.set({ first: { index:1 }, second: { index:2 }, third: { index:3 } });
you get:
{"items":[{"index":1,"$id":"first"},{"index":2,"$id":"second"},{"index":3,"$id":"third"}]}

Case 2: array of primitives; you pass in:
firebaseRef.set(["first", "second", "third"]);
You now get:
{"items":["first","second","third"]}
You propose:
{"items":[{$id: 0, $value: "first"}, {$id: 1, $value: "second"}, {$id: 2, $value: "third"}]}

That it? Or am I missing something? Test cases most welcome. :-)

[jwngr]

Yup, that's pretty much it. That is what we do with AngularFire and I think it works out pretty well.

[puf]

OK. I got that one working easily, but of course then some of the original
tests that use primitives are failing (since they don't do .$value). I'll
change those and update the PR.

On Wed, May 27, 2015 at 3:03 PM, Jacob Wenger notifications@github.com
wrote:

Yup, that's pretty much it. That is what we do with AngularFire and I
think it works out pretty well.

—
Reply to this email directly or view it on GitHub
#40 (comment).

[jwngr]

Sounds good. We definitely do need to update the test suite and will also probably need to list this as a breaking change. I'm totally up for doing that though since this is strictly improved functionality.

[puf]

@jwngr Update the tests and fixed a few more case. Back to you.

[AndrewBestbier]

Thank you for this!

[jwngr]

Thanks for this PR @puf! I made a few changes myself (renamed $id to $key and fixed issue with sparse arrays) and then merged this in. Time to crank out a few more fixes for other issues and get an updated version of ReactFire out there.