-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Channel ID from Commit #90
Comments
is there workaround? |
my workaround was to manually specify the - name: Deploy to Firebase (preview)
uses: FirebaseExtended/action-hosting-deploy@v0
with:
repoToken: '${{ secrets.GITHUB_TOKEN }}'
firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT }}'
expires: 3d
projectId: my-project-id
channelId: 'pr-${{ github.event.number }}-${{ github.event.pull_request.head.ref }}' I get a warning about unsupported characters ( |
Any constant channel ID can be provided in |
None of these 'solutions' work. |
I use instead |
Currently have it setup that PR onto the dev or main branch trigger deployment of a preview, but would be great if a preview deployment could be triggered on a merge - Currently no channel id gets generated in this case resulting in an error and a failed action because no channel id is supplied
The sha or subject of the commit on a push could be used to generate the channel Id instead, allowing for this use case
The text was updated successfully, but these errors were encountered: