Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override of the import validation #16

Closed
dmanners opened this issue Jun 28, 2017 · 2 comments
Closed

Override of the import validation #16

dmanners opened this issue Jun 28, 2017 · 2 comments

Comments

@dmanners
Copy link

We have a system currently using the import export module. When the csv validation has issues not from the FireBear validation but from the standard Magento import validation process these will get overridden.

In the Firebear\ImportExport\Model\Job\Processor::process method when it catches an exception it will load the history and set the summary. But the Magento validation has already added the appropriate log messages to the history for this process. The end result is that when you get <b>Data validation is failed. Please fix errors and re-upload the file..</b> in the summary and not the "real" error message as provided by the Magento core import validation.

@biotech
Copy link
Member

biotech commented Jun 28, 2017

Hi David! Thanks for you notice, we will for sure fix that. We are working now on complete refactoring and improved achitecture of paid version, will be released soon and available for downloads for all customers

@dmanners
Copy link
Author

Thank you for the information @biotech

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants