Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quoting database name #78

Merged
merged 4 commits into from Oct 20, 2022
Merged

fix: quoting database name #78

merged 4 commits into from Oct 20, 2022

Conversation

ptiurin
Copy link
Collaborator

@ptiurin ptiurin commented Oct 17, 2022

Description

This fixes the issue we were having when database name had mixed-case letters. Quoting ensures the casing is preserved.

TESTs

Run both jaffle shop and pytest tests. Confirmed users can override the value in dbt-project.yml

Checklist

  • I have run this code in development and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required/relevant for this PR.
  • I have updated CHANGELOG.md and added information about my change.
  • I have removed any print or log calls that were added for debugging.
  • If this PR requires a new PyPI release I have bumped the version number.
  • I have verified that this PR contains only code changes relevant to this PR.
  • If further integration tests are now passing I've edited firebolt.dbtspec to account for this.
  • I have pulled/merged from the main branch if there are merge conflicts.
  • After pulling/merging main I have run pytest on the included or updated firebolt.dbtspec.

@ptiurin ptiurin marked this pull request as ready for review October 17, 2022 13:23
@ptiurin
Copy link
Collaborator Author

ptiurin commented Oct 20, 2022

mypy issue in CI is due to specifically python=3.7 and dbt-core=1.3.0, I filed a separate ticket to investigate https://packboard.atlassian.net/browse/FIR-16420

@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ptiurin ptiurin merged commit e3abdf7 into main Oct 20, 2022
@ptiurin ptiurin deleted the fix-quoting-database branch October 20, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants