Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove redundant mat test #83

Merged
merged 1 commit into from Dec 7, 2022
Merged

refactor: Remove redundant mat test #83

merged 1 commit into from Dec 7, 2022

Conversation

ptiurin
Copy link
Collaborator

@ptiurin ptiurin commented Dec 6, 2022

Ref #71

Description

Removing redundant materialisation which is already implemented on the dbt-core side.

Checklist

  • I have run this code in development and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required/relevant for this PR.
  • I have updated CHANGELOG.md and added information about my change.
  • I have removed any print or log calls that were added for debugging.
  • If this PR requires a new PyPI release I have bumped the version number.
  • I have verified that this PR contains only code changes relevant to this PR.
  • If further integration tests are now passing I've edited tests/functional/adapter/test_basic.py to account for this.
  • I have pulled/merged from the main branch if there are merge conflicts.
  • After pulling/merging main I have run pytest on the included or updated tests/functional/adapter/test_basic.py.

@ptiurin ptiurin changed the title ref: Remove redundant mat test refactor: Remove redundant mat test Dec 6, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ptiurin
Copy link
Collaborator Author

ptiurin commented Dec 6, 2022

Verified via tests and jaffle shop (test) run.

@ptiurin ptiurin merged commit d43885a into main Dec 7, 2022
@ptiurin ptiurin deleted the ref-redundancies branch December 7, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants