Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making firebug's Style Side Panel aware of less css & Sass debug info #45

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Making firebug's Style Side Panel aware of less css & Sass debug info #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
18a441c
Make firebug aware of less css framework debug output to improve accu…
jc4rp3nt3r Oct 1, 2012
61f8ebd
Forgot FBTrace version of cssPanel.js
jc4rp3nt3r Oct 1, 2012
f6aa124
Added additional code to account for Sass comments too... if we are g…
jc4rp3nt3r Oct 1, 2012
040c37c
Refactor to comply with firebug coding preactices
jc4rp3nt3r Oct 2, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
42 changes: 40 additions & 2 deletions extension/content/firebug/css/cssPanel.js
View file
Open in desktop
Expand Up @@ -1448,14 +1448,52 @@ Firebug.CSSStyleSheetPanel.prototype = Obj.extend(Firebug.Panel,
getSourceLink: function(target, rule)
{
var element = rule.parentStyleSheet.ownerNode;
var line = getRuleLine(rule);
var instance = Css.getInstanceForStyleSheet(rule.parentStyleSheet);
var href = rule.parentStyleSheet.href; // Null means inline

// http://code.google.com/p/fbug/issues/detail?id=452
if (!href)
href = element.ownerDocument.location.href;

// if this is a less/sass file
var sFileType = (href.indexOf('.less') !== -1) ? 'less' :
(href.indexOf('.sass') !== -1) ? 'sass' : null;
if (sFileType) {
var oDoc = Css.getDocumentForStyleSheet(rule.parentStyleSheet),
oStyleSheet = oDoc ? oDoc.styleSheets[instance] : null;

if(oStyleSheet && this.context.sourceCache) {
// a counter for the current line index
var iLineIndex = line-1;
// handle to the css doc, type = array of text strings per line
var arrCss = this.context.sourceCache.load(oStyleSheet.href);
// dotLess format: /* /path/css-file.less:L123 */ sass format: /* line 20, sass/_reset.sass */
var regEx = (sFileType === 'less') ? /\/\* ([^:]*):L(\d*) \*\// :
(sFileType === 'sass') ? /\/\* line (\d*), ([^ ]*) \*\// :
null;

// prevent index out of bounds and stop looking after 5 lines
while(iLineIndex >= 0 && line - iLineIndex < 5) {
if (regEx.test(arrCss[iLineIndex])) {
// update the file and line numbers for both less and Sass style comments
var arrMatch = arrCss[iLineIndex].match(regEx);

if (sFileType === 'less') {
href = arrMatch[1];
line = arrMatch[2];
}
else if (sFileType === 'sass') {
href = arrMatch[2];
line = arrMatch[1];
}
break;
}
iLineIndex -= 1;
}
}
}

var line = getRuleLine(rule);
var instance = Css.getInstanceForStyleSheet(rule.parentStyleSheet);
var sourceLink = new SourceLink.SourceLink(href, line, "css", rule, instance);

return sourceLink;
Expand Down
42 changes: 40 additions & 2 deletions trace/FBTrace/chrome/firebug/content/css/cssPanel.js
View file
Open in desktop
Expand Up @@ -1375,14 +1375,52 @@ Firebug.CSSStyleSheetPanel.prototype = Obj.extend(Firebug.Panel,
getSourceLink: function(target, rule)
{
var element = rule.parentStyleSheet.ownerNode;
var line = getRuleLine(rule);
var instance = Css.getInstanceForStyleSheet(rule.parentStyleSheet);
var href = rule.parentStyleSheet.href; // Null means inline

// http://code.google.com/p/fbug/issues/detail?id=452
if (!href)
href = element.ownerDocument.location.href;

// if this is a less/sass file
var sFileType = (href.indexOf('.less') !== -1) ? 'less' :
(href.indexOf('.sass') !== -1) ? 'sass' : null;
if (sFileType) {
var oDoc = Css.getDocumentForStyleSheet(rule.parentStyleSheet),
oStyleSheet = oDoc ? oDoc.styleSheets[instance] : null;

if(oStyleSheet && this.context.sourceCache) {
// a counter for the current line index
var iLineIndex = line-1;
// handle to the css doc, type = array of text strings per line
var arrCss = this.context.sourceCache.load(oStyleSheet.href);
// dotLess format: /* /path/css-file.less:L123 */ sass format: /* line 20, sass/_reset.sass */
var regEx = (sFileType === 'less') ? /\/\* ([^:]*):L(\d*) \*\// :
(sFileType === 'sass') ? /\/\* line (\d*), ([^ ]*) \*\// :
null;

// prevent index out of bounds and stop looking after 5 lines
while(iLineIndex >= 0 && line - iLineIndex < 5) {
if (regEx.test(arrCss[iLineIndex])) {
// update the file and line numbers for both less and Sass style comments
var arrMatch = arrCss[iLineIndex].match(regEx);

if (sFileType === 'less') {
href = arrMatch[1];
line = arrMatch[2];
}
else if (sFileType === 'sass') {
href = arrMatch[2];
line = arrMatch[1];
}
break;
}
iLineIndex -= 1;
}
}
}

var line = getRuleLine(rule);
var instance = Css.getInstanceForStyleSheet(rule.parentStyleSheet);
var sourceLink = new SourceLink.SourceLink(href, line, "css", rule, instance);

return sourceLink;
Expand Down