Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Closes #108 (Fix default behavior of double_width)
- Loading branch information
Showing
2 changed files
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8b1b473
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, with double_width=None, you would get the auto behavior and T/F would always force the choice. With this change, double_width=False is auto, and 'None' disables double-width. Is this intended?
8b1b473
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would assume (wrongly perhaps :) ) if the doc string calls for a boolean, then people would either supply True or False. I guess changing line 139 to:
would be more generous in allowing the 'auto' behavior?
8b1b473
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.