Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Shim OOM score to +1 of containerd #217

Closed
sipsma opened this issue Jun 28, 2019 · 3 comments
Closed

Change Shim OOM score to +1 of containerd #217

sipsma opened this issue Jun 28, 2019 · 3 comments
Assignees
Labels
exp/beginner good first issue Good for newcomers kind/enhancement New feature or request

Comments

@sipsma
Copy link
Contributor

sipsma commented Jun 28, 2019

Containerd recently updated their reference shim implementations to set the OOM score of the shim to +1 that of the parent containerd process:

This should allow the shim's to
be killed first in an OOM condition but leave the daemon alone for a bit
to help cleanup and manage the containers during this situation.

We should probably make the same change here but can't quite re-use their code because the fc-control plugin actually runs in the same process as containerd, so it needs to set the shim score to +1 of its own (not of the parent process).

@sipsma sipsma added kind/enhancement New feature or request good first issue Good for newcomers exp/beginner labels Jun 28, 2019
@praveensastry
Copy link
Contributor

@sipsma I'd like to contribute to this.

@sipsma
Copy link
Contributor Author

sipsma commented Jul 24, 2019

@praveensastry Sounds great, thanks! Please feel free to reach out on this issue or email if we can help clarify anything in the process

@sipsma
Copy link
Contributor Author

sipsma commented Aug 2, 2019

Closed by #238

@sipsma sipsma closed this as completed Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/beginner good first issue Good for newcomers kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants