Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRI conformance tests #88

Open
xibz opened this issue Feb 7, 2019 · 3 comments
Open

CRI conformance tests #88

xibz opened this issue Feb 7, 2019 · 3 comments
Labels

Comments

@xibz
Copy link
Contributor

xibz commented Feb 7, 2019

The runtime should be CRI conformant. To verify that the runtime is we need to run a set of tests to ensure this provided by containerd, ie CRI validation tests, CRI e2e (end to end) tests.

The validation tests should be implemented first due to e2e tests taking a long amount of time due to if something doesn't work, it'll timeout in 2 minutes for each test.

CRI Validation Test Issues:
#90 #91 #92 #93 #94 #95 #96 #97 #98 #99 #100 #101 #102 #103

@xibz xibz added this to the CRI milestone Feb 7, 2019
@xibz xibz added the area/cri label Feb 7, 2019
@xibz xibz removed this from the CRI milestone Feb 7, 2019
@kzys
Copy link
Contributor

kzys commented Aug 30, 2019

Note that firecracker-contained binary we built is currently not having cri plugin, whereas containerd includes the plugin by default.

Building cri with firecracker-containerd should be possible, but it would add a bunch of "replace" directives on our go.mod, due to the way Kubernetes manages Go packages.

@alexandrevilain
Copy link

Hi @kzys !

Containerd is now supporting go modules (containerd/containerd#4760) and cri has been moved to containerd's main repo (https://github.com/containerd/containerd/tree/master/pkg/cri).

It think that we can work back on this issue.

Would you like to update #255 ? Or I can create a new one if you don't have time to work on it :)

@acpana
Copy link
Contributor

acpana commented Apr 15, 2021

@kzys is there an opportunity for us to resume work here? Or is this issue complete via #255 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants