Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support forcing CNI network creation even if delete of pre-existing network fails #130

Closed
sipsma opened this issue Sep 19, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@sipsma
Copy link
Contributor

sipsma commented Sep 19, 2019

In reference to the current code's attempt to delete a pre-existing network for a given VM, I've now encountered in the wild a plugin (the firewall CNI plugin) that consistently fails here due to a previous result not being available (which goes against what the CNI spec says).

While we can fix this problem upstream, we should probably also include the ability for users to optionally override failing at that line (perhaps via something like a Force parameter in the CNI configuration) in order to allow use of CNI plugins that aren't perfectly compliant. The default behavior should stay the same though and if the error is overridden with the Force parameter then the error needs to be logged still.

@sipsma sipsma added the enhancement New feature or request label Sep 19, 2019
@Zyqsempai
Copy link
Contributor

I will work on this one!

@sipsma
Copy link
Contributor Author

sipsma commented Nov 7, 2019

I will work on this one!

Sounds great, thanks! Let me know if you need any more context on the change

@sipsma
Copy link
Contributor Author

sipsma commented Nov 19, 2019

Closed by #161

@sipsma sipsma closed this as completed Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants