Rust toolchain upgrade 1.64 -> 1.66 for Firecracker v1.1 #3342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreitraistaru
force-pushed
the
firecracker-v1.1
branch
4 times, most recently
from
a022d39
to
ddbdff2
Compare
andreitraistaru
force-pushed
the
firecracker-v1.1
branch
4 times, most recently
from
0ea70c1
to
59a1e22
Compare
andreitraistaru
changed the title
andreitraistaru
force-pushed
the
firecracker-v1.1
branch
2 times, most recently
from
5e96bdf
to
75adbbd
Compare
|
Fixed that. Thank you! |
JonathanWoollett-Light
previously approved these changes
Dec 29, 2022
Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk> (cherry picked from commit 4ae37a4)
Signed-off-by: Trăistaru Andrei Cristian <atc@amazon.com> (cherry picked from commit f67ef5c)
As a result of the Rust toolchain upgrade from 1.65 to 1.66, several clippy errors appeared (most of them being clippy::unneccesary_cast). This commit fixes these errors. Signed-off-by: Traistaru Andrei Cristian <atc@amazon.com> (cherry picked from commit 0de96ce)
The previous approach was to iterate through the known attached file descriptors, we now instead iterate through and attempt to close all possible attached file descriptors. This offers a more robust and safe implementation. This fixes a bug which arises in Rust versions >=1.65.0 from a file descriptor being closed twice. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk> (cherry picked from commit f79c94d)
This commit switches to black for checking python checkstyle. The code changes done in the *py files are generated automatically by runnig `black .` from the firecracker/tests directory in the devctr. Signed-off-by: Traistaru Andrei Cristian <atc@amazon.com>
andreitraistaru
force-pushed
the
firecracker-v1.1
branch
from
75adbbd
to
9b7248b
Compare
Signed-off-by: Traistaru Andrei Cristian <atc@amazon.com>
Signed-off-by: Traistaru Andrei Cristian <atc@amazon.com>
andreitraistaru
force-pushed
the
firecracker-v1.1
branch
from
9b7248b
to
2146b40
Compare
JonathanWoollett-Light
approved these changes
Dec 29, 2022
roypat
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
Rust toolchain upgrade from 1.64 to 1.66.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
git commit -s).unsafecode is documented.CHANGELOG.md.TODOs link to an issue.rust-vmm.