Testing cpuid #3355
Merged
Testing cpuid #3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanWoollett-Light
force-pushed
the
testing-cpuid
branch
from
403d7ed
to
2af76c2
Compare
9 tasks
JonathanWoollett-Light
force-pushed
the
testing-cpuid
branch
4 times, most recently
from
eb829a5
to
33a909f
Compare
JonathanWoollett-Light
force-pushed
the
testing-cpuid
branch
10 times, most recently
from
a3f002d
to
b973bec
Compare
JonathanWoollett-Light
force-pushed
the
testing-cpuid
branch
2 times, most recently
from
a8eed86
to
67466de
Compare
JonathanWoollett-Light
force-pushed
the
feature/cpu-templates
branch
from
c74aec0
to
447f3bb
Compare
JonathanWoollett-Light
force-pushed
the
testing-cpuid
branch
2 times, most recently
from
396824d
to
7a87b5d
Compare
JonathanWoollett-Light
force-pushed
the
feature/cpu-templates
branch
from
447f3bb
to
c5e6b3d
Compare
JonathanWoollett-Light
force-pushed
the
testing-cpuid
branch
from
7a87b5d
to
1949e5c
Compare
pb8o
previously approved these changes
Feb 1, 2023
JonathanWoollett-Light
force-pushed
the
testing-cpuid
branch
2 times, most recently
from
edf8ea6
to
ff94434
Compare
pb8o
previously approved these changes
Feb 1, 2023
zulinx86
reviewed
Feb 1, 2023
JonathanWoollett-Light
force-pushed
the
testing-cpuid
branch
3 times, most recently
from
ba1ea99
to
278dea1
Compare
Refactors `cpuid::intel::IntelCpuid::default_brand_string` to add tests. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
Additional tests for `cpuid::common::get_cpuid`. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
Fixes behaviour of `RawCpuid::push` and `RawCpuid::pop`, and removes `RawCpuid::resize`. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
Simple tests for `CpuidTrait::get` and `CpuidTrait::get_mut`. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
JonathanWoollett-Light
force-pushed
the
testing-cpuid
branch
from
278dea1
to
57f2599
Compare
zulinx86
reviewed
Feb 1, 2023
Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
Change `Intel(4)` to `Intel(R)` from the Intel brand string under cpuid. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
JonathanWoollett-Light
force-pushed
the
testing-cpuid
branch
from
57f2599
to
c040469
Compare
zulinx86
approved these changes
Feb 2, 2023
pb8o
approved these changes
Feb 3, 2023
JonathanWoollett-Light
merged commit 45fd924
into
firecracker-microvm:feature/cpu-templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds additional testing onto the
cpuidcrate in thefeature/cpu-templatesfeature branch.Reason
Increases safety.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
git commit -s).unsafecode is documented.CHANGELOG.md.TODOs link to an issue.rust-vmm.