Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test the jailer #363

Closed
dianpopa opened this issue Jun 20, 2018 · 5 comments
Closed

Unit test the jailer #363

dianpopa opened this issue Jun 20, 2018 · 5 comments
Assignees
@pkj415
Labels
Good first issue Indicates a good issue for first-time contributors Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled

Comments

@dianpopa
Copy link
Contributor

Kcov reports 0% coverage for all the files that are jailer related.
@dianpopa dianpopa added this to the Customer 2 Production milestone Jun 20, 2018
@raduweiss raduweiss removed this from the Customer 2 Production milestone Nov 20, 2018
@andreeaflorescu andreeaflorescu added the Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled label Nov 22, 2018
@dianpopa dianpopa added the Good first issue Indicates a good issue for first-time contributors label Nov 26, 2018
@dianpopa
Copy link
Contributor Author

Coverage reported for jailer crate right now: 42.6%. Not closing this issue yet since there is room for improvement, see above.
cov.zip

@edigaryev edigaryev mentioned this issue May 4, 2020
Merged
8 tasks
@lauralt lauralt mentioned this issue Jun 2, 2020
Merged
8 tasks
@pkj415
Copy link
Contributor

pkj415 commented Sep 21, 2020

Interested in working on this to ramp up on Firecracker! (Just some context - I am a graduate student at UT trying to know more about Firecracker and will be working with Xiang Gu).

Does commenting here implicitly mean this issue gets assigned to me?

@dianpopa
Copy link
Contributor Author

Hi @pkj415 ,

Are you still interested in working on this issue? I will assign it to you after confirmation.

@pkj415
Copy link
Contributor

pkj415 commented Nov 14, 2020

Hi @dianpopa, yes you can assign this to me. Sorry for the delay in reply, I missed this notification somehow.

@dianpopa
Copy link
Contributor Author

All the unit testable jailer code is covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkj415 pkj415

Labels
Good first issue Indicates a good issue for first-time contributors Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@andreeaflorescu @dianpopa @alexandruag @pkj415 @raduweiss