Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namespace features are not correctly extracted across scopes #721

Closed
williballenthin opened this issue Aug 10, 2021 · 0 comments · Fixed by #722
Closed

namespace features are not correctly extracted across scopes #721

williballenthin opened this issue Aug 10, 2021 · 0 comments · Fixed by #722
Assignees
Labels
bug Something isn't working
Milestone

Comments

@williballenthin
Copy link
Collaborator

during the traige of #703, i've found that we don't correctly extract matched namespaces across scopes. that is, given a function-scope rule that matches, its namespaces are not extracted for matching at the file-scope.

this is relevant for the file limitation rules, e.g. "packer file limitation" (file-scope) that looks for namespace "anti-analysis/packer". this can match "packed with UPX" (file-scope) because the namespaces are extracted correctly within the same scope; however, "packed with generic packer" (function-scope) is not matched because the namespaces are not extracted from function scope into file scope.

this results in false negatives in which we'd expect some rules to match but they don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant