Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add capa release link to capa-rules tag #517

Merged
merged 1 commit into from Apr 8, 2021

Conversation

Ana06
Copy link
Member

@Ana06 Ana06 commented Apr 7, 2021

GitHub displays the commit's message of the tag if no description is given, which is ugly. Use annotated tags which include a message. Use the release link as message, as this is useful information.

This is the difference between a tag created with the previous action and with the changes:

Screenshot 2021-04-07 at 18 59 16

Type of change

Please update the CHANGELOG.md

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made the corresponding changes to the documentation
  • Other

Tests

  • I have added tests that prove my fix is effective or that my feature works
  • No new tests needed

GitHub displays the commit's message of the tag if no description is
given, which is ugly. Use annotated tags which include a message. Use
the release link as message, as this is useful information.
@Ana06 Ana06 merged commit 255d6ea into mandiant:master Apr 8, 2021
@Ana06 Ana06 deleted the better-tag branch April 8, 2021 08:49
Ana06 added a commit that referenced this pull request May 7, 2021
Add to the changelog that we now update `New Rules` section in CHANGELOG
automatically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants