ci: lint CHANGELOG #604
Merged
ci: lint CHANGELOG #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sync GH action in capa-rules relies on a single '- *$' in the CHANGELOG file. Check in the tests that this is the case to avoid that it is removed. This happened in the following PR: mandiant#591 This caused that the new rules in the following PR were not added to the CHANGELOG: mandiant/capa-rules#400
mr-tz
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sync GH action in capa-rules relies on a single
- *$in the CHANGELOG file. Check in the tests that this is the case to avoid that it is removed.This happened in #591, which caused that the new rules in mandiant/capa-rules#400 were not added to the CHANGELOG.
There are probably better alternatives to update the CHANGELOG than looking for
- *$. Any ideas of how to do this in a robuster way that doesn't need linting? 馃 Otherwise this is an easy solution which may be good enough.Checklist