Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 616 #618

Merged
merged 2 commits into from Jun 9, 2021
Merged

fix 616 #618

merged 2 commits into from Jun 9, 2021

Conversation

mike-hunhoff
Copy link
Collaborator

fixes #616 and improves display for function-name features.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed

@github-actions github-actions bot dismissed their stale review June 8, 2021 16:17

CHANGELOG updated or no update needed, thanks! 😄

capa/features/file.py Show resolved Hide resolved
# display no preview
return CapaExplorerFeatureItem(parent, display=display)
return CapaExplorerFeatureItem(parent, location=location, display=display)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated fix.

capa/features/file.py Show resolved Hide resolved
Co-authored-by: Willi Ballenthin <willi.ballenthin@gmail.com>
@mr-tz
Copy link
Collaborator

mr-tz commented Jun 9, 2021

thanks, works now!

@mr-tz mr-tz merged commit 9ffbb82 into master Jun 9, 2021
@mr-tz mr-tz deleted the fix/616 branch June 9, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ida explorer: functionname feature not supported
3 participants