Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRCListener ServerName configuration is read multiple times #38

Closed
strictlymike opened this issue Aug 5, 2017 · 0 comments
Closed

IRCListener ServerName configuration is read multiple times #38

strictlymike opened this issue Aug 5, 2017 · 0 comments

Comments

@strictlymike
Copy link
Collaborator

The IRCListener class uses .get('servername', 'localhost') to get its ServerName configuration value the first time in order to make the setting optional with the default value 'localhost'; but its ThreadedTCPRequestHandler accesses self.server.config['servername'] directly, resulting in a KeyError that winds up closing connections to the IRC service. Replacing direct references to self.server.config['servername'] with self.server.servername in the ThreadedTCPRequestHandler seems to resolve this and make the ServerName setting truly optional.

iphelix added a commit that referenced this issue Aug 31, 2017
…onal

Replace refs to config[servername] fixes #38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant