Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete translation of validation notices. #1118

Closed
Nik-vr opened this issue Jan 10, 2018 · 5 comments
Closed

Incomplete translation of validation notices. #1118

Nik-vr opened this issue Jan 10, 2018 · 5 comments
Assignees
Labels
enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release).
Milestone

Comments

@Nik-vr
Copy link

Nik-vr commented Jan 10, 2018

When validating the warning forms, the field names are in English. Although the signatures to these fields have been translated. As a result, the warning turns out to be incomprehensible, because field names do not match.

validation

Perhaps, when forming messages, use not the internal names of fields, but the translated signatures to them?

@JC5
Copy link
Member

JC5 commented Jan 10, 2018

I don't think I can. The messages are pushed by Laravel. But I shall do some digging.

@JC5
Copy link
Member

JC5 commented Jan 10, 2018

Turns out I can! I've uploaded new strings.

Please note that the word "add_tag" and other values in the error below can not be translated.

screen shot 2018-01-10 at 12 25 16

@JC5 JC5 self-assigned this Jan 10, 2018
@JC5 JC5 added enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release). labels Jan 10, 2018
@JC5 JC5 added this to the 4.7.0 milestone Jan 10, 2018
@Nik-vr
Copy link
Author

Nik-vr commented Jan 10, 2018

Excellent! I will translate a new line. And it is impossible to substitute not new lines, but existing signatures for fields? So there will be fewer lines for translation and fewer possible errors.

@JC5
Copy link
Member

JC5 commented Jan 10, 2018

Unfortunately, Crowdin does not allow it. There are quite a few lines which are "double" and you have to translate them two or three times. It cannot be helped.

@Nik-vr
Copy link
Author

Nik-vr commented Jan 10, 2018

Ok, no problem!

@JC5 JC5 closed this as completed Jan 31, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants