Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer.lock should not be ignored in .dockerignore #1541

Closed
chrif opened this issue Jul 8, 2018 · 1 comment
Closed

composer.lock should not be ignored in .dockerignore #1541

chrif opened this issue Jul 8, 2018 · 1 comment
Labels
enhancement Requests for enhancements of existing stuff.

Comments

@chrif
Copy link

chrif commented Jul 8, 2018

Bug description
I am running Firefly III version 4.7.5

I noticed that composer.lock is ignored when copying files to the docker container, prior to running composer install. It is however saved to version control. Correct me if I'm wrong, but this means that people installing Firefly III on a self-hosted server following the procedure with composer create-project will end up with the versions in the composer.lock file while those using Docker ends up with whatever is resolved by composer install with no lock file when building the container.

If that is so, then you end up with users running the same version of Firefly III with potentially different vendor versions.

@chrif chrif changed the title composer.lock should not be ignored in .dockerignore composer.lock should not be ignored in .dockerignore Jul 8, 2018
@JC5
Copy link
Member

JC5 commented Jul 8, 2018

Indeed, I’ll check it out.

@JC5 JC5 added the enhancement Requests for enhancements of existing stuff. label Jul 9, 2018
@JC5 JC5 added this to 4.7.8 in Firefly III roadmap Jul 12, 2018
@JC5 JC5 closed this as completed in 76386da Jul 14, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests for enhancements of existing stuff.
Projects
No open projects
Development

No branches or pull requests

2 participants