Fix LDAP auth configuration paths. #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Seems docs for ldap upgrade were half-complete. Please rename the migration. Will inspect later when I have a PC |
|
What convention should the migration be named after? |
|
Not after a version three releases ago. I suggest fix_ldap or something. Keep it simple. |
This commit fixes parameters broken in the latest version of `adldap2`.
Specifically:
* `adldap` auth parameters have changed in the latest version.
* "usernames" has become `identities` and `discover` has changed to
`discover_users_by`, `auth` has changed to `bind_users_by`
* Add the missing objectguid field to the users table for adldap2.
* This is added as a nullable (optional) field at the moment to support
tracking LDAP users as adldap2 wants to.
|
Looks good. |
JC5
added a commit
that referenced
this pull request
Mar 16, 2019
JC5
added a commit
that referenced
this pull request
Mar 22, 2019
* develop: (21 commits) Update lock file Update change logs and config files. Enable norsk, update version of DB Various language string updates. Norwegian strings. Improve installer middleware for Sandstorm. Fix some issues with importer #2166 Other delete thing. More debug things. Extra debug info for #2159 and some kernel changes. Extra debug info for #2159 Fix #2173 Rename class and add copyright statement @wrouesnel #2167 Fix LDAP auth configuration paths. Fix some cache issues and a version bump. Updated file list. Updated list. New file list. Update composer file. Small fix in changelog. ...
|
@wrouesnel would you mind posting an example of what your .env file looks like with this change? Upon upgrading to this version I am unable to authenticate with FreeIPA again, but as you were able to get this working I'm assuming it is down to a slight configuration issue on my end. |
|
@MrShibe A (sanitized) version of the LDAP section of my config file |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes parameters broken in the latest version of
adldap2.Specifically:
adldapauth parameters have changed in the latest version.identitiesanddiscoverhas changed todiscover_users_by,authhas changed tobind_users_bytracking LDAP users as adldap2 wants to.
Fixes issue #1933 (completely).
Changes in this pull request:
objectguidconfig/ldap_auth.phpto match upadldap2With these changes I was able to get authentication with FreeIPA working correctly versus current master.
@JC5