Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Available budget showing total for all user accounts #2687

Closed
mercianix opened this issue Oct 4, 2019 · 1 comment
Closed

Available budget showing total for all user accounts #2687

mercianix opened this issue Oct 4, 2019 · 1 comment
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).

Comments

@mercianix
Copy link

Hi, I am running Firefly III version 4.8.1.1 and I have two users on my installation. When entering the budgeted monthly amounts for either user, the total displayed is the sum total of the budgeted amounts for both users instead of the amount for the user currently in use.

image

Steps to reproduce

  1. Add a budget under a user account and populate with a value.
  2. Create a second user account, add a budget and populate with any value.
  3. View budgets under any user and total available shows sum of both budgets.

Expected behaviour
Total available budget should be for that user account only, not the total including other users. For the above screenshot, I expect to see £1,650 budgeted as that is the actual amount for that user.

Additional
The budget_limits table does not contain user_id and I believe it either could do, or the query could just join to budgets on the active user_id to filter?

Let me know if you need any additional information!

@JC5
Copy link
Member

JC5 commented Oct 5, 2019

Nice find. That's sloppy. A fix will go out asap.

@JC5 JC5 added bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release). labels Oct 5, 2019
@JC5 JC5 closed this as completed in 9b001f7 Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants