Fix recurring transactions create and fix cache access #3598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maroux
force-pushed
the
fix_recurring_create
branch
from
d30b6c7
to
da02f7f
Compare
maroux
changed the title
- If there's a lot of accounts to calculate balances for, then recurring transactions create page doesn't load. Partly because it has to calculate a lot of balances, but partly because the cache isn't being used at all because date is `new Date` rather than say, end of month. Fix: Change Steam balance calculator to always default cache using end of month. Since cache is 'invalidated' upon any edit, there's no reason to use current datetime anywhere its not explicitly required by user flow. Fix: Don't calculate balances for revenue / expense accounts since those are unbounded. Issue: firefly-iii#3597
maroux
force-pushed
the
fix_recurring_create
branch
from
928bb3b
to
9d409a7
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #3597
Root cause:
doesn't load. Partly because it has to calculate a lot of balances, but partly because the cache
isn't being used at all because date is
new Cobrarather than say, end of month.Changes in this pull request:
'invalidated' upon any edit, there's no reason to use current datetime anywhere its not explicitly
required by user flow.
auto complete form).
Test Plan:
/recurring/createand it loaded fine (albeit slow).Steamin logs => cache was used.@JC5