Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of Docker when not running Docker #3639

Merged
merged 2 commits into from
Aug 2, 2020
Merged

Remove mention of Docker when not running Docker #3639

merged 2 commits into from
Aug 2, 2020

Conversation

sephrat
Copy link
Contributor

@sephrat sephrat commented Aug 2, 2020

Following d774b4e, I suggest to remove Docker mention since this block is displayed only when not running Docker.

@JC5

Not sure what's your politic about unused strings, let me know if you want me to remove it (same for my other PR).

@JC5
Copy link
Member

JC5 commented Aug 2, 2020

You can drop the sentence as well. Just remove it from the en_US, the rest follows automatically. Thanks!

@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 4 Code Smells

No Coverage information No Coverage information
2.8% 2.8% Duplication

@sephrat
Copy link
Contributor Author

sephrat commented Aug 2, 2020

Done!

@JC5 JC5 merged commit bb6f484 into firefly-iii:develop Aug 2, 2020
@JC5
Copy link
Member

JC5 commented Aug 2, 2020

Merged! 👍

@sephrat sephrat deleted the docker-locale branch August 2, 2020 13:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants