Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piggy bank events are not being created #3745

Closed
JeroenED opened this issue Aug 29, 2020 · 9 comments
Closed

Piggy bank events are not being created #3745

JeroenED opened this issue Aug 29, 2020 · 9 comments
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).

Comments

@JeroenED
Copy link
Contributor

Bug description
I am running Firefly III version 5.3.3, and my problem is: When creating a transaction that is link to a piggy bank the link is not created

Steps to reproduce

  1. Create a piggy bank (if you don't have one)
  2. Create a transaction and select the piggy bank in the piggy bank selector

Extra info
Browser: Firefox 80.0 + Chrome 85.0 (Both show the same issue)
OS: Pop_OS! Linux 20.04.1

Bonus points

  • I checked the logs and database myself and found that the transaction does contains correct piggy bank id without name and that there is simply no record in the piggy_bank_events table
@JC5
Copy link
Member

JC5 commented Aug 29, 2020

I just verified this, and it seems to work for me. However

  • The transaction you make must be a transfer.
  • In the same currency as the piggy bank.
  • Involving the account of the piggy bank in either the source or destination account.

Here's an example from the demo site (until it resets):

@JC5 JC5 added the question label Aug 29, 2020
@JeroenED
Copy link
Contributor Author

JeroenED commented Aug 30, 2020

Hi @JC5,

I saw the demo transactions and I even was able to create piggy transactions myself on the demo environment. This being said it is clear (at least to me) that the issue in connected to the environment or settings.

Here you can find debug logs as I suspect they might be interesting.
ff3-audit-2020-08-30.log
ff3-fpm-fcgi-2020-08-30.log

And here are some more details on my environment. If you would need any more informations, please let me know.

$ php -v
PHP 7.4.9 (cli) (built: Aug  7 2020 14:30:01) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.9, Copyright (c), by Zend Technologies

$ cat /etc/os-release 
NAME="Ubuntu"
VERSION="20.04.1 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.1 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

// Since database is SQLite
$ php -r "print_r(SQLite3::version());"
Array
(
    [versionString] => 3.31.1
    [versionNumber] => 3031001
)

@JC5
Copy link
Member

JC5 commented Aug 31, 2020

Thanks, i'll check it out. Not sure what's going on.

@stale
Copy link

stale bot commented Sep 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale No replies or comments. Will be auto-closed in 14 days. label Sep 7, 2020
@JeroenED
Copy link
Contributor Author

JeroenED commented Sep 7, 2020

Hi @JC5 Do you have any results on the research already. I started to think it might be connected to a change in PHP7.4. i'll try to verify it this evening as I'm not sure if true or not.

@stale stale bot removed the stale No replies or comments. Will be auto-closed in 14 days. label Sep 7, 2020
@JC5
Copy link
Member

JC5 commented Sep 7, 2020

There's not enough info in the log files to be sure what the cause is but I've added some details and a potential fix for the most obvious culprit. This will be included in the next release. Thanks for reminding me.

@JC5 JC5 added bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release). and removed question labels Sep 7, 2020
@JC5 JC5 closed this as completed in ff6c0c2 Sep 13, 2020
@JC5
Copy link
Member

JC5 commented Sep 13, 2020

Closed because beta 1 is out.

@JeroenED
Copy link
Contributor Author

Hi, I just installed the beta and can confirm the issue is resolved!

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants