Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erroneous message when changing currencies #4121

Closed
robpedersendev opened this issue Dec 3, 2020 · 7 comments
Closed

Erroneous message when changing currencies #4121

robpedersendev opened this issue Dec 3, 2020 · 7 comments
Labels
stale No replies or comments. Will be auto-closed in 14 days.

Comments

@robpedersendev
Copy link

Bug description
I am running Firefly III version 5.4.6, and my problem is: Erroneous message for non-admin users when they update their currencies
image

Steps to reproduce

Under Options/Currencies, I have the test account select a curreny and mark as default. The page loads, the currency is set, but I get the message "Message: Please ask mail@example.com to add, remove or edit currencies." in a blue box at the top of the screen.

Extra info

Windows 10
Firefox
Debug information generated at 2020-12-03 18:33:34 Europe/Amsterdam for Firefly III version 5.4.6.

Scope Version
Firefly III 5.4.6
Firefly III API 1.4.0
PHP 7.4.12
Host Linux
System info Value
Installation ID 83d86322-900c-4c2c-a22d-2de0af37236f
Using docker? false
Telemetry false
Layout
App environment local
App debug mode false
App cache driver file
App logging notice, stdout
Display errors Off
Error reporting ALL errors
Interface apache2handler
Default language en_US
Default locale equal
BCscale 12
DB drivers mysql, pgsql, sqlite, sqlsrv
Current driver pgsql
DB version 15 (exp. 15)
Login provider ldap
Trusted proxies (.env) **
User info Value
Session start 2020-12-01 00:00:00
Session end 2020-12-31 23:59:59
Session first 2020-01-01 00:00:00
User ID 3
User language en_US
User locale en_US
Attempt at "en_US.utf8" 'en_US.utf8'
Attempt at "en_US.UTF-8" 'en_US.UTF-8'
User agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:83.0) Gecko/20100101 Firefox/83.0

Bonus points

X I searched and nobody reported this bug before
X I have added a stack trace from my log files
X I have added a screenshot.
X I was able to replicate it on the demo site https://demo.firefly-iii.org/

@JC5
Copy link
Member

JC5 commented Dec 3, 2020

The message is designed to be there. You need to be admin to add, remove or edit currencies. I'll make it more clear in the new layout 👍

The email address on display can be set in your environment variables.

@JC5 JC5 added the question label Dec 3, 2020
@robpedersendev
Copy link
Author

Even when you change your default currency?

@robpedersendev
Copy link
Author

The message is designed to be there. You need to be admin to add, remove or edit currencies. I'll make it more clear in the new layout 👍

The email address on display can be set in your environment variables.

Thank you for this, this solved it

@JC5
Copy link
Member

JC5 commented Dec 3, 2020

Even when you change your default currency?

Yes, but the user experience is pretty bad so it deserves a better format in the new layout.

@robpedersendev
Copy link
Author

Understood, ok. This can be closed if that is better for you.

Thanks for the quick reply

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale No replies or comments. Will be auto-closed in 14 days. label Dec 18, 2020
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale No replies or comments. Will be auto-closed in 14 days.
Projects
None yet
Development

No branches or pull requests

2 participants