Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more than 3 digit currency codes #4759

Closed
JamborJan opened this issue May 9, 2021 · 4 comments
Closed

more than 3 digit currency codes #4759

JamborJan opened this issue May 9, 2021 · 4 comments
Labels
enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release).

Comments

@JamborJan
Copy link

JamborJan commented May 9, 2021

Description
The import extension crypto-trades-firefly-iii allows to import transactions from Binance. Therefore it is required to add all currencies in firefly-iii. Right now firefly allows only 3 digit currency codes which are not enough for cryptocurrencies e.g. AAVE BETH COTI LINK IOTA etc.

Solution
It should be possible to have more than 3 digit currency codes. I'm not aware of any standard here. making it only 4 would also not be sufficient. There are things out there like OCEAN etc.

What are alternatives?
Firefly III and the extension are not usable for all currencies out there.

Additional context
N/A

Bonus points
N/A

@JC5
Copy link
Member

JC5 commented May 9, 2021

ISO 4217.

@JamborJan
Copy link
Author

Thanks for that hint. I guess that's rather for fiat currencies and not for cryptocurrencies, right? I don't see any of the cryptocurrencies which are in the default list of firefly-iii in ISO-4217 either. I did a quick check and as far as I can tell, there is no real standard for cryptocurrency symbols (aka codes).

@JC5
Copy link
Member

JC5 commented May 10, 2021

I can extend the option to five or even seven letters, but it'll be a few versions before this will be implemented.

@JC5 JC5 added the enhancement Requests for enhancements of existing stuff. label May 10, 2021
@JamborJan
Copy link
Author

Thanks a lot @JC5. And thanks also for the great work you are doing. Much appreciated.

@JC5 JC5 added this to Planned / To Do in Roadmap to 5.6.0 May 10, 2021
@JC5 JC5 moved this from Planned / To Do to Done! in Roadmap to 5.6.0 Jun 10, 2021
@JC5 JC5 added the fixed Bugs that are fixed (in a coming release). label Jun 10, 2021
@JC5 JC5 closed this as completed Jul 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release).
Projects
No open projects
Development

No branches or pull requests

2 participants