Develop #5279
Merged
Develop #5279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea! 👍 |
|
Only thing I realise (after merging) is that you can drop the OpenLDAP check; it's the default anyway. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sorry, that was my "better safe than sorry" approach since I'm not familiar with the code base. I'll whip up another PR. |
StillLoading
added a commit
to StillLoading/firefly-iii
that referenced
this pull request
Nov 13, 2021
JC5
added a commit
that referenced
this pull request
Nov 13, 2021
Drop default case. OpenLDAP is already the default (see #5279)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw the (partial) fix for #5231 and noticed it did not include FreeIPA. So I fumbled this together.
This is just a suggestion on how to handle the available models. You don't have to use it as is, I can change it if it doesn't fit your code style/scheme.