advance payment tags are broken

[worldworm]

I think the tagging system is broken (or i didn't get it)
I created a new advance payment tag. Then I added a withdrawal with this tag. Everything works here.
But when i create a deposit to repay that expense, the tag disappers after saving (not the tag, only the connection to this deposit)

[JC5]

I think it's a bug:

[2017-03-06 09:10:24] production.DEBUG: Existing journal #532 is a withdrawal.  
[2017-03-06 09:10:24] production.DEBUG: New journal #533 must have these destination accounts: 33  
[2017-03-06 09:10:24] production.DEBUG: New journal #533 actually these destination accounts: 1  
[2017-03-06 09:10:24] production.DEBUG: So match is FALSE  

The "must have" part should be 1.

I'll see if I can't fix this real quick!

[JC5]

Fixed! Do a git pull and you should be good.

Problem was caused by a sloppy copy/paste action by me.

[worldworm]

Great, it works.
Thanks!

[worldworm]

Hey there,
updatet to Version 4.3.7 today. Tags are working like a charm, big thanks!

Only want to inform you, that this problem (above) is still happening on the old tag, expense, withdrawal (the tags and transactions where i discovered this problem on (created in the old version where the bug happened)).
When you create a new tag AND transactions it is working.

For me it isn't a problem (so no stress here :) ), i created everything new. I only want to let you know it, so you can decide if it needs a closer look

[JC5]

It is possible that this is cache related, but I will look into the issue. The "calculation" is live but parts of it may be cached.

You could run php artisan cache:clear to see what happens.

Thanks for pointing this out 👍 !